Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update Branch" button on PR #9750

Closed
techknowlogick opened this issue Jan 13, 2020 · 6 comments · Fixed by #9784
Closed

"Update Branch" button on PR #9750

techknowlogick opened this issue Jan 13, 2020 · 6 comments · Fixed by #9784

Comments

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jan 13, 2020

Related #8659

Similar to GitHub when a branch on a PR is out of sync, then an "Updated Branch" button could be used to merge commits from upstream into PR branch (assuming no merge conflicts)

@techknowlogick

This comment has been minimized.

Copy link
Member Author

@techknowlogick techknowlogick commented Jan 13, 2020

@zeripath

This comment has been minimized.

Copy link
Contributor

@zeripath zeripath commented Jan 13, 2020

An extension that would also be needed is to make the author suggestions ignore these merge commits too.

@davidsvantesson

This comment has been minimized.

Copy link
Contributor

@davidsvantesson davidsvantesson commented Jan 14, 2020

Maybe all commits which is merge from target shall be ignored as authors, even if not done in UI?

@zeripath

This comment has been minimized.

Copy link
Contributor

@zeripath zeripath commented Jan 14, 2020

Exactly!

@6543 6543 mentioned this issue Jan 15, 2020
13 of 13 tasks complete
@davidsvantesson

This comment has been minimized.

Copy link
Contributor

@davidsvantesson davidsvantesson commented Jan 15, 2020

Maybe something to add in the future:
isaacs/github#1419

@6543

This comment has been minimized.

Copy link
Member

@6543 6543 commented Jan 16, 2020

working on it .. to isaacs/github#1419 I plan to reuse a lot of the normal merge code ... so to extend the function should be easy (but I like get the a simple PR in first, extend afterwards)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.