Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if go exists before generating the GOPATH #10100

Merged
merged 4 commits into from Feb 2, 2020

Conversation

@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2020

Fix #10084

@zeripath zeripath added this to the 1.12.0 milestone Feb 1, 2020
@lafriks
lafriks approved these changes Feb 1, 2020
@GiteaBot GiteaBot added the lgtm/need 1 label Feb 1, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 2, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 2, 2020

Codecov Report

Merging #10100 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10100      +/-   ##
==========================================
+ Coverage   43.48%   43.49%   +<.01%     
==========================================
  Files         567      568       +1     
  Lines       79104    79108       +4     
==========================================
+ Hits        34400    34406       +6     
+ Misses      40454    40453       -1     
+ Partials     4250     4249       -1
Impacted Files Coverage Δ
cmd/embedded_stub.go 0% <0%> (ø)
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo.go 51.46% <0%> (+0.13%) ⬆️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️
services/pull/check.go 56.64% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635b44d...9fd5d19. Read the comment docs.

@techknowlogick techknowlogick merged commit 391e063 into go-gitea:master Feb 2, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.