Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Git Setup #10122

Open
wants to merge 1 commit into
base: master
from
Open

[Docs] Git Setup #10122

wants to merge 1 commit into from

Conversation

@bagasme
Copy link
Contributor

bagasme commented Feb 3, 2020

As title.

Installing Git from binary package and source

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@29151b9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10122   +/-   ##
=========================================
  Coverage          ?   43.41%           
=========================================
  Files             ?      576           
  Lines             ?    79632           
  Branches          ?        0           
=========================================
  Hits              ?    34570           
  Misses            ?    40785           
  Partials          ?     4277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29151b9...4645faf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 3, 2020
@lafriks
lafriks approved these changes Feb 3, 2020
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 3, 2020
@lafriks lafriks added the kind/docs label Feb 3, 2020
@sapk
sapk approved these changes Feb 3, 2020
@sapk

This comment has been minimized.

Copy link
Member

sapk commented Feb 3, 2020

@bagasme can you add a link here to this page on ?

Check that Git is installed on the server. If it is not, install it first.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 3, 2020
Copy link
Member

techknowlogick left a comment

I’m unsure if we need this entire page for instructions on installing git, especially if we link to git-scm.org for most of it. There are links below that would need to be updated and monitored for changes, where the official git site already handles that

@jolheiser

This comment has been minimized.

Copy link
Member

jolheiser commented Feb 3, 2020

Perhaps just adding some links to the binary page or FAQ? In my opinion, building Git from source is out of scope for Gitea documentation.

EDIT: But thank you for the documentation PRs regardless! 🙌

@6543

This comment has been minimized.

Copy link
Member

6543 commented Feb 3, 2020

@jolheiser if git users lookup gitea's docs because it has more infos then we made it 😆

@bagasme

This comment has been minimized.

Copy link
Contributor Author

bagasme commented Feb 4, 2020

@techknowlogick git-scm.com site mention this (build from source) on Pro Git.

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Feb 4, 2020

I'm not concerned about specifically building from source, but rather there links to specific tar bundles that would need to be updated, as well as reviewing the link you just posted the content covers the same but in greater detail. Maybe instead you could add a small note to the installation page that mentions git is also required and link to the page that you just did so that we don't need to maintain it and the official docs from git will always be most accurate and most maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.