Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue sidebar menus having an infinite height #10239

Merged
merged 2 commits into from Feb 11, 2020

Conversation

@jamesorlakin
Copy link
Contributor

jamesorlakin commented Feb 11, 2020

A partial revert of #10216, yet still an attempt at fixing #10218. This PR sets the max-height property to a different selector so it fixes the assignee menu too.

Before:
image

After:
image

I'm willing to create a backport for v1.11, as it is quite noticetable on my production instance! 馃槃

@jamesorlakin jamesorlakin changed the title Bugfix/long sidebar menu Fix issue sidebar menus having an infinite height Feb 11, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #10239 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10239      +/-   ##
==========================================
- Coverage   43.68%   43.67%   -0.02%     
==========================================
  Files         582      582              
  Lines       80048    80048              
==========================================
- Hits        34966    34957       -9     
- Misses      40747    40754       +7     
- Partials     4335     4337       +2
Impacted Files Coverage 螖
modules/indexer/stats/db.go 55.17% <0%> (-10.35%) 猬囷笍
services/pull/temp_repo.go 29.05% <0%> (-2.57%) 猬囷笍
services/pull/patch.go 60.37% <0%> (-2.52%) 猬囷笍
services/pull/check.go 32.92% <0%> (-2.44%) 猬囷笍
modules/queue/workerpool.go 50.17% <0%> (酶) 猬嗭笍
modules/log/event.go 65.64% <0%> (+1.02%) 猬嗭笍
modules/process/manager.go 78.31% <0%> (+3.61%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d9c7998...5d2add8. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 11, 2020
@lafriks lafriks added the kind/ui label Feb 11, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 11, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 11, 2020
@lafriks lafriks merged commit 54af3c9 into go-gitea:master Feb 11, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Feb 11, 2020

Please send backport

@jamesorlakin

This comment has been minimized.

Copy link
Contributor Author

jamesorlakin commented Feb 11, 2020

Already done ;). I forgot to set the title properly though! #10240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can鈥檛 perform that action at this time.