Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hanging issue indexer initialisation from preventing shutdown #10243

Merged
merged 3 commits into from Feb 11, 2020

Conversation

@zeripath
Copy link
Contributor

zeripath commented Feb 11, 2020

If the issue indexer hangs during initialisation and times out previously this code would prevent the shutdown of Gitea.

This code moves the initialisation out of a graceful RunWithShutdown().

@zeripath zeripath added this to the 1.12.0 milestone Feb 11, 2020
@jaqra
jaqra approved these changes Feb 11, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 11, 2020
lafriks and others added 2 commits Feb 11, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #10243 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10243      +/-   ##
==========================================
- Coverage    43.7%   43.66%   -0.04%     
==========================================
  Files         582      582              
  Lines       80047    80047              
==========================================
- Hits        34983    34953      -30     
- Misses      40732    40758      +26     
- Partials     4332     4336       +4
Impacted Files Coverage Δ
services/pull/check.go 31.09% <0%> (-7.32%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-5.13%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
models/error.go 30.4% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e082...90a5ec1. Read the comment docs.

@sapk sapk merged commit 1125d14 into go-gitea:master Feb 11, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@sapk

This comment has been minimized.

Copy link
Member

sapk commented Feb 11, 2020

Please send backport

@zeripath zeripath deleted the zeripath:ensure-issue-index-timeout-can-finish branch Feb 12, 2020
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 12, 2020
…o-gitea#10243)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
lafriks added a commit that referenced this pull request Feb 12, 2020
…10243) (#10249)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 14, 2020
…o-gitea#10243)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.