Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in login sources #10428

Merged
merged 3 commits into from Feb 23, 2020
Merged

Various fixes in login sources #10428

merged 3 commits into from Feb 23, 2020

Conversation

@guillep2k
Copy link
Member

guillep2k commented Feb 23, 2020

  • Only autoregister users from external login sources (eg. PAM and SMTP authentication) if the username is valid i.e. [A-Za-z0-9_.-]+ NOTE: This is a breaking change.

  • Call pam_get_item(PAM_USER...) to allow PAM pipelines to adjust the username

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 23, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@0b74dfe). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10428   +/-   ##
=========================================
  Coverage          ?   43.67%           
=========================================
  Files             ?      586           
  Lines             ?    81386           
  Branches          ?        0           
=========================================
  Hits              ?    35544           
  Misses            ?    41439           
  Partials          ?     4403
Impacted Files Coverage Δ
modules/notification/webhook/webhook.go 40.66% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b74dfe...905b058. Read the comment docs.

@jolheiser jolheiser merged commit 09dbd85 into go-gitea:master Feb 23, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 23, 2020
lafriks pushed a commit that referenced this pull request Feb 23, 2020
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.