Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud oauth #10562

Merged
merged 8 commits into from Mar 3, 2020
Merged

nextcloud oauth #10562

merged 8 commits into from Mar 3, 2020

Conversation

@techknowlogick
Copy link
Member

techknowlogick commented Mar 1, 2020

fix #7078

@techknowlogick techknowlogick added this to the 1.12.0 milestone Mar 1, 2020
@techknowlogick

This comment has been minimized.

Copy link
Member Author

techknowlogick commented Mar 2, 2020

Ready for review

@GiteaBot GiteaBot added the lgtm/need 2 label Mar 2, 2020
Copy link
Contributor

zeripath left a comment

Looks good but I do admit I know nothing about nextcloud

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 3, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #10562 into master will decrease coverage by <.01%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10562      +/-   ##
==========================================
- Coverage   43.71%   43.71%   -0.01%     
==========================================
  Files         585      585              
  Lines       82035    82026       -9     
==========================================
- Hits        35863    35856       -7     
+ Misses      41729    41728       -1     
+ Partials     4443     4442       -1
Impacted Files Coverage Δ
modules/git/command.go 89.56% <ø> (ø) ⬆️
routers/api/v1/repo/pull.go 34.63% <0%> (ø) ⬆️
services/pull/pull.go 34.7% <0%> (-1.37%) ⬇️
services/pull/review.go 0% <0%> (ø) ⬆️
routers/repo/issue.go 38% <0%> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
routers/repo/pull.go 29.05% <40%> (+0.44%) ⬆️
modules/convert/pull.go 72.17% <57.14%> (+1.09%) ⬆️
services/pull/merge.go 49.34% <8.33%> (-0.12%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa4ab6...545e26c. Read the comment docs.

@techknowlogick techknowlogick merged commit bea497f into go-gitea:master Mar 3, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@techknowlogick techknowlogick deleted the techknowlogick:nextcloud-oauth branch Mar 3, 2020
everhopingandwaiting added a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.