Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release attachments being deleted while upgrading #10572

Merged
merged 1 commit into from Mar 2, 2020

Conversation

@lunny
Copy link
Member

lunny commented Mar 2, 2020

Fix #10526

When it's iterating, you should not delete anything on the same table. I think it's why the bug occured.

And the old code also just Cols("uuid") but it deleted the attachement by id but it's zero. This PR also fixed that.

@lunny lunny added this to the 1.12.0 milestone Mar 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 label Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 2, 2020
@guillep2k guillep2k merged commit 753c067 into go-gitea:master Mar 2, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
guillep2k added a commit to guillep2k/gitea that referenced this pull request Mar 2, 2020
@lunny lunny deleted the lunny:lunny/fix_migrate branch Mar 2, 2020
guillep2k added a commit to guillep2k/gitea that referenced this pull request Mar 2, 2020
jolheiser pushed a commit that referenced this pull request Mar 2, 2020
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
jolheiser pushed a commit that referenced this pull request Mar 2, 2020
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath changed the title Fix migration bug on v96.go Fix release attachments being deleted while upgrading Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.