Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of DefaultCommandExecutionTimeout to match docs #10581

Merged
merged 2 commits into from Mar 3, 2020

Conversation

@zeripath
Copy link
Contributor

zeripath commented Mar 2, 2020

Set the default git timeout to 360s as per the docs not 60s.

Fix #10575

…sheet
@zeripath zeripath added the kind/bug label Mar 2, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 label Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 2, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 2, 2020

Codecov Report

Merging #10581 into master will decrease coverage by 0.01%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10581      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.02%     
==========================================
  Files         585      585              
  Lines       82014    82005       -9     
==========================================
- Hits        35864    35849      -15     
- Misses      41711    41716       +5     
- Partials     4439     4440       +1
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 34.63% <0%> (ø) ⬆️
services/pull/pull.go 35.88% <0%> (-0.19%) ⬇️
services/pull/review.go 0% <0%> (ø) ⬆️
routers/repo/issue.go 38% <0%> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
services/pull/temp_repo.go 29.05% <0%> (ø) ⬆️
routers/repo/pull.go 29.05% <40%> (+0.44%) ⬆️
modules/convert/pull.go 72.17% <57.14%> (+1.09%) ⬆️
services/pull/merge.go 49.34% <8.33%> (-0.12%) ⬇️
models/pull.go 43.33% <81.57%> (+0.96%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1937...af7db43. Read the comment docs.

@guillep2k guillep2k merged commit 07f6ae3 into go-gitea:master Mar 3, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@zeripath zeripath deleted the zeripath:fix-10575 branch Apr 1, 2020
everhopingandwaiting added a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.