Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout POST action #10582

Merged
merged 4 commits into from Mar 3, 2020
Merged

Logout POST action #10582

merged 4 commits into from Mar 3, 2020

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented Mar 3, 2020

Tried to make it a form and it broke the CSS, so it's a link-action instead. 🤷‍♂️

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@6543
Copy link
Member

6543 commented Mar 3, 2020

kind securety ?

@codecov-io
Copy link

Codecov Report

Merging #10582 into master will increase coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10582      +/-   ##
==========================================
+ Coverage   43.71%   43.75%   +0.03%     
==========================================
  Files         585      585              
  Lines       82005    82026      +21     
==========================================
+ Hits        35850    35888      +38     
+ Misses      41716    41704      -12     
+ Partials     4439     4434       -5
Impacted Files Coverage Δ
models/oauth2.go 34.04% <ø> (ø) ⬆️
modules/auth/oauth2/oauth2.go 24.15% <28.57%> (+0.59%) ⬆️
modules/indexer/stats/db.go 50% <0%> (-9.38%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/git/repo.go 47.7% <0%> (-1.38%) ⬇️
models/error.go 29.23% <0%> (+0.51%) ⬆️
models/gpg_key.go 53.95% <0%> (+0.52%) ⬆️
models/notification.go 64.71% <0%> (+0.83%) ⬆️
services/pull/pull.go 35.88% <0%> (+0.88%) ⬆️
modules/indexer/issues/indexer.go 57.52% <0%> (+1.32%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c4b63...308503d. Read the comment docs.

@jolheiser jolheiser merged commit 0e2217b into go-gitea:master Mar 3, 2020
@jolheiser jolheiser deleted the post-logout branch March 3, 2020 04:50
jolheiser added a commit to jolheiser/gitea that referenced this pull request Mar 3, 2020
* Change logout to POST

* Update for redirect

* Revert octicon to font

Signed-off-by: jolheiser <john.olheiser@gmail.com>
lunny pushed a commit that referenced this pull request Mar 3, 2020
* Change logout to POST

* Update for redirect

* Revert octicon to font

Signed-off-by: jolheiser <john.olheiser@gmail.com>
everhopingandwaiting pushed a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
* Change logout to POST

* Update for redirect

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants