Make PR message on pushes configurable #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
guillep2k
approved these changes
Mar 8, 2020
| @@ -428,14 +429,14 @@ func HookPostReceive(ctx *macaron.Context, opts private.HookOptions) { | |||
| branch = fmt.Sprintf("%s:%s", repo.OwnerName, branch) | |||
| } | |||
| results = append(results, private.HookPostReceiveBranchResult{ | |||
| Message: true, | |||
| Message: setting.Git.PullRequestPushMessage && repo.AllowsPulls(), | |||
There was a problem hiding this comment.
I think that this would have been good enough, though.
Message: repo.AllowsPulls(),There was a problem hiding this comment.
I more or less agree, but we may as well make it configurable for those who don't want the extra messages.
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 8, 2020
GiteaBot
added
lgtm/done
|
Ping mr lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5801
This PR adds a global config to enable/disable the new PR message on pushing
e.g.
It also suppresses the message if the repo in question has PRs disabled.