Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PACKAGES to GO_PACKAGES for FreeBSD compatibility #10747

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@guillep2k
Copy link
Member

guillep2k commented Mar 17, 2020

Closes #10727

@guillep2k guillep2k added this to the 1.12.0 milestone Mar 17, 2020
@lunny
lunny approved these changes Mar 17, 2020
Copy link
Member

techknowlogick left a comment

We must first examine downstream dependencies who may change this, I believe either arch or alpine may use this variable in their package building.

@guillep2k

This comment has been minimized.

Copy link
Member Author

guillep2k commented Mar 17, 2020

We must first examine downstream dependencies who may change this, I believe either arch or alpine may use this variable in their package building.

I have no idea how to check that. 😅

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Mar 17, 2020

Looks like from alpine we are fine: https://github.com/alpinelinux/aports/blob/4a9faac93b5e4d8ac2dfa9ffaf270c12aa447bc5/community/gitea/APKBUILD
and from arch we are fine too https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/gitea

I think I was remembering how alpine uses the env var, but it seems in way unrelated to the makefile. As such I will dismiss my review.

@techknowlogick techknowlogick dismissed their stale review Mar 17, 2020

reviewed alpine and arch

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 17, 2020
@lafriks lafriks merged commit 10e8da1 into go-gitea:master Mar 17, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@guillep2k guillep2k deleted the guillep2k:fix-10727 branch Mar 18, 2020
everhopingandwaiting added a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
)

Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.