Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JS build dependencies to 'dependencies' #10763

Merged
merged 1 commit into from Mar 19, 2020
Merged

Conversation

@silverwind
Copy link
Member

silverwind commented Mar 18, 2020

Move JS build dependencies to 'dependencies'

  • move all JS build dependencies to 'dependencies'
  • update all JS dependencies

Reason for this is that npm will only install 'dependencies' when under the effect of NODE_ENV=production which may be present on some build systems.

Linters currently need to be dependencies because we run linting as part of the build step, but I plan to move them to a separate 'lint' target which means they can move to devDependencies then.

Fixes: #10761

- move all JS build dependencies to 'dependencies'
- update all JS dependencies

Reason for this is that npm will only install 'dependencies' when under
the effect of NODE_ENV=production which may be present on some build
systems.

Linters currently need to be depdendencies because we run linting as
part of the build step, but I plan to move them to a separate 'lint'
target which means they can move to devDependencies then.

Fixes: #10761
@jolheiser jolheiser added this to the 1.12.0 milestone Mar 18, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 19, 2020
@lunny lunny merged commit 661289d into go-gitea:master Mar 19, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@silverwind silverwind deleted the silverwind:pkgdeps branch Mar 19, 2020
everhopingandwaiting added a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
- move all JS build dependencies to 'dependencies'
- update all JS dependencies

Reason for this is that npm will only install 'dependencies' when under
the effect of NODE_ENV=production which may be present on some build
systems.

Linters currently need to be depdendencies because we run linting as
part of the build step, but I plan to move them to a separate 'lint'
target which means they can move to devDependencies then.

Fixes: go-gitea#10761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.