Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch api canPush and canMerge #10776

Merged
merged 2 commits into from Mar 21, 2020

Conversation

@lunny
Copy link
Member

lunny commented Mar 20, 2020

#10767 missed to fix UserCanPush and UserCanMerge, this PR will fix them. It should not be always true even if there is no branch protection. It depends if user login and have permission to write to the code unit.

@lunny lunny added this to the 1.12.0 milestone Mar 20, 2020
@lunny lunny added the backport/done label Mar 20, 2020
@guillep2k

This comment has been minimized.

Copy link
Member

guillep2k commented Mar 21, 2020

Ping LG-TM

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Mar 21, 2020
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 21, 2020
@techknowlogick techknowlogick merged commit dcaa564 into go-gitea:master Mar 21, 2020
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lunny lunny deleted the lunny:lunny/fix_branch_api3 branch Mar 21, 2020
everhopingandwaiting added a commit to everhopingandwaiting/gitea that referenced this pull request Apr 4, 2020
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.