Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid '0 new commits' messages to be send to webhook #11082

Merged
merged 3 commits into from Apr 18, 2020
Merged

Avoid '0 new commits' messages to be send to webhook #11082

merged 3 commits into from Apr 18, 2020

Conversation

cornelk
Copy link
Contributor

@cornelk cornelk commented Apr 15, 2020

Fixes #10498

@lafriks lafriks added this to the 1.12.0 milestone Apr 15, 2020
6543
6543 approved these changes Apr 16, 2020
@6543
Copy link
Member

6543 commented Apr 16, 2020

looks good - since only on push you will have new commits

Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right.

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 6034f8b into go-gitea:master Apr 18, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 12, 2020

Should be marked as breaking possibly, Drone did depend on this to fetch additional data for tags https://github.com/drone/drone/blob/c81263687c4af650e4a0d05444f2fc5a1541e5be/service/hook/parser/parse.go#L189

An issue was also raised that it might be an undesired regression - harness/drone#2966 (comment)

zeripath added a commit that referenced this pull request May 13, 2020
lafriks pushed a commit that referenced this pull request May 13, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Slack webhook showing message 0 new commits pushed
8 participants