Revert "Avoid '0 new commits' messages to be send to webhook" #11397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6034f8b.
|
Relevant harness/drone#2966 (comment) |
kolaente
approved these changes
May 13, 2020
CirnoT
approved these changes
May 13, 2020
jonasfranz
approved these changes
May 13, 2020
|
@CirnoT - I see you've had 10 PRs merged - would you like to apply to be a maintainer? |
|
I can confirm this fixes it for drone on my instance - thanks! |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…-gitea#11397) This reverts commit 6034f8b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reverts #11082
As per comments by @CirnoT this breaks drone and likely other things as it directly moves us away from GitHub behaviour.
The 0 commits information should be handled elsewhere.
Reopens #10498