Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the base url when migrating from Gitlab using access token or username without password #11852

Merged
merged 2 commits into from Jun 11, 2020
Merged

Set the base url when migrating from Gitlab using access token or username without password #11852

merged 2 commits into from Jun 11, 2020

Conversation

gernoteger
Copy link
Contributor

@gernoteger gernoteger commented Jun 11, 2020 •
edited by zeripath

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix #11851

zeripath
zeripath approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my little understanding of this code - this appears correct

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 11, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 11, 2020
@zeripath zeripath changed the title fixing #11851: using baseUrl with access token Use provided base url when migrating from Gitlab using access token or username without password Jun 11, 2020
@zeripath zeripath changed the title Use provided base url when migrating from Gitlab using access token or username without password Set the base url when migrating from Gitlab using access token or username without password Jun 11, 2020
@zeripath
Copy link
Contributor

Have adjusted title and summary to more match our current system.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2020
@6543
Copy link
Member

6543 commented Jun 11, 2020

yep it should not make problems - since SelfHosted GitLab is not supported jet (UI is blocking this)
but better change it now

@zeripath zeripath merged commit a3fe9d8 into go-gitea:master Jun 11, 2020
@zeripath
Copy link
Contributor

Please send backport

zeripath pushed a commit to zeripath/gitea that referenced this pull request Jul 1, 2020
@gernoteger @zeripath
Set the base url when migrating from Gitlab using access token or use…
43d7d7e 
…rname without password (go-gitea#11852)

Backport go-gitea#11852

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix go-gitea#11851
@zeripath zeripath mentioned this pull request Jul 1, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Jul 1, 2020
lunny added a commit that referenced this pull request Jul 2, 2020
@zeripath @gernoteger @lunny
Set the base url when migrating from Gitlab using access token or use…
d737eaa 
…rname without password (#11852) (#12104)

Backport #11852

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix #11851

Co-authored-by: Gernot Eger <gernot.eger@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@gernoteger
Set the base url when migrating from Gitlab using access token or use…
789b642 
…rname without password (go-gitea#11852)

When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password

Fix go-gitea#11851
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

migrations: NewGitlabDownloader() will ignore baseUrl when using access token
5 participants
@gernoteger @zeripath @6543 @techknowlogick @GiteaBot