Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dropzone's timeout (#12024) #12032

Merged
merged 1 commit into from Jun 24, 2020
Merged

Disable dropzone's timeout (#12024) #12032

merged 1 commit into from Jun 24, 2020

Conversation

silverwind
Copy link
Member

Backport #12024

@silverwind @lunny
Disable dropzone's timeout (go-gitea#12024)
c5e990b 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jun 24, 2020
@techknowlogick techknowlogick added this to the 1.12.2 milestone Jun 24, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2020
@techknowlogick techknowlogick merged commit d059156 into go-gitea:release/v1.12 Jun 24, 2020
@silverwind silverwind deleted the backport-12024 branch June 24, 2020 15:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @lunny @mrsdizzie @techknowlogick @GiteaBot