Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue popups #14898

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix issue popups #14898

merged 1 commit into from
Mar 5, 2021

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented Mar 5, 2021 •
edited by zeripath
Loading

Prevent XSS in issue popups

@jolheiser jolheiser added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.13 labels Mar 5, 2021
@jolheiser jolheiser added this to the 1.14.0 milestone Mar 5, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 5, 2021
@zeripath zeripath merged commit f1da466 into go-gitea:master Mar 5, 2021
@jolheiser jolheiser deleted the issue-popup branch March 5, 2021 21:00
@6543
Copy link
Member

6543 commented Mar 5, 2021

@zeripath pleace backport

jolheiser added a commit to jolheiser/gitea that referenced this pull request Mar 5, 2021
@jolheiser
Signed-off-by: jolheiser <john.olheiser@gmail.com> (go-gitea#14898)
2c9e3d3
@jolheiser jolheiser mentioned this pull request Mar 5, 2021
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Mar 5, 2021
lafriks pushed a commit that referenced this pull request Mar 5, 2021
@jolheiser
Signed-off-by: jolheiser <john.olheiser@gmail.com> (#14898) (#14899)
7d3e174
@jolheiser jolheiser added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 12, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jolheiser @6543 @lafriks @zeripath @GiteaBot