From c9c5c5c815c4df7846f72f32a3ad9296da36245c Mon Sep 17 00:00:00 2001 From: silverwind Date: Mon, 12 Apr 2021 19:13:57 +0200 Subject: [PATCH 1/3] Project board improvements - Fix link colors - Extract CSS to own file - Various minor tweaks to make it look better Fixes: https://github.com/go-gitea/gitea/issues/15424 Fixes: https://github.com/go-gitea/gitea/issues/15506 Fixes: https://github.com/go-gitea/gitea/pull/15511 --- templates/repo/projects/view.tmpl | 36 +++++------ web_src/js/features/projects.js | 2 + web_src/less/_base.less | 22 +++++-- web_src/less/_repository.less | 76 ----------------------- web_src/less/features/projects.less | 77 ++++++++++++++++++++++++ web_src/less/index.less | 1 + web_src/less/themes/theme-arc-green.less | 5 +- 7 files changed, 117 insertions(+), 102 deletions(-) create mode 100644 web_src/less/features/projects.less diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index aa6abf05110b..802571293c65 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -73,13 +73,13 @@ {{ range $board := .Boards }}
-
-
{{.Title}}
+
+
{{.Title}}
{{if and $.CanWriteProjects (not $.Repository.IsArchived) $.PageIsProjects (ne .ID 0)}} -
- - {{svg "octicon-kebab-horizontal" 24}} - +
+
+ {{svg "octicon-kebab-horizontal"}} +
{{svg "octicon-pencil"}} @@ -156,9 +156,9 @@
-
+
- + {{if .IsPull}} {{if .PullRequest.HasMerged}} {{svg "octicon-git-merge" 16 "text purple"}} @@ -177,17 +177,17 @@ {{end}} {{end}} - #{{.Index}} {{.Title}} + #{{.Index}} {{.Title}}
{{- if .MilestoneID }} -
+
- {{svg "octicon-milestone"}} {{ .Milestone.Name }} + {{svg "octicon-milestone" 16 "mr-2"}}{{ .Milestone.Name }}
{{- end }} {{- range index $.LinkedPRs .ID }} -
+
{{svg "octicon-git-merge"}} {{ .Title}} (#{{ .Index }}) @@ -195,11 +195,13 @@
{{- end }}
-
- {{ range .Labels }} - {{.Name | RenderEmoji}} - {{ end }} -
+ {{if .Labels}} +
+ {{ range .Labels }} + {{.Name | RenderEmoji}} + {{ end }} +
+ {{end}}
diff --git a/web_src/js/features/projects.js b/web_src/js/features/projects.js index 91e5c208500e..0d619cab70ba 100644 --- a/web_src/js/features/projects.js +++ b/web_src/js/features/projects.js @@ -14,6 +14,7 @@ export default async function initProject() { group: 'board-column', draggable: '.board-column', animation: 150, + ghostClass: 'card-ghost', onSort: () => { const board = document.getElementsByClassName('board')[0]; const boardColumns = board.getElementsByClassName('board-column'); @@ -42,6 +43,7 @@ export default async function initProject() { { group: 'shared', animation: 150, + ghostClass: 'card-ghost', onAdd: (e) => { $.ajax(`${e.to.dataset.url}/${e.item.dataset.issue}`, { headers: { diff --git a/web_src/less/_base.less b/web_src/less/_base.less index cb1cd18e3d66..366ee073b4c0 100644 --- a/web_src/less/_base.less +++ b/web_src/less/_base.less @@ -111,6 +111,7 @@ --color-expand-button: #d8efff; --color-placeholder-text: #aaa; --color-editor-line-highlight: var(--color-primary-light-6); + --color-project-board-bg: var(--color-secondary-light-4); /* backgrounds */ --checkbox-mask-checked: url('data:image/svg+xml;utf8,'); --checkbox-mask-indeterminate: url('data:image/svg+xml;utf8,'); @@ -442,6 +443,16 @@ a.muted:hover, color: var(--color-text); } +.ui.cards > .card .meta > a:not(.ui), +.ui.card .meta > a:not(.ui) { + color: var(--color-text-light-2); +} + +.ui.cards > .card .meta > a:not(.ui):hover, +.ui.card .meta > a:not(.ui):hover { + color: var(--color-text); +} + .ui.cards a.card:hover, .ui.link.cards .card:not(.icon):hover, a.ui.card:hover, @@ -450,6 +461,12 @@ a.ui.card:hover, background: var(--color-card); } +.ui.cards > .card > .extra, +.ui.card > .extra { + color: var(--color-text); + border-top-color: var(--color-secondary-light-1) !important; +} + .ui.comments .comment .text, .ui.comments .comment .author { color: var(--color-text); @@ -1733,11 +1750,6 @@ a.ui.basic.label:hover { margin-bottom: .4em; } -.ui.cards > .card > .extra, -.ui.card > .extra { - color: var(--color-text); -} - .color-icon { display: inline-block; border-radius: 100%; diff --git a/web_src/less/_repository.less b/web_src/less/_repository.less index 6042a7594899..7e6f398f3f3b 100644 --- a/web_src/less/_repository.less +++ b/web_src/less/_repository.less @@ -2940,82 +2940,6 @@ tbody.commit-list { padding-top: 0 !important; } -.board { - display: flex; - flex-direction: row; - flex-wrap: nowrap; - overflow-x: auto; - margin: 0 .5em; -} - -.board-column { - background-color: rgba(0, 0, 0, .05) !important; - border: 1px solid var(--color-secondary) !important; - margin: 0 .5rem !important; - padding: .5rem !important; - width: 320px; - height: 60vh; - overflow-y: scroll; - flex: 0 0 auto; - overflow: visible; - display: flex; - flex-direction: column; -} - -.board-column-header { - display: flex; - justify-content: space-between; -} - -.board-label { - background: none !important; - line-height: 1.25 !important; -} - -.board-column > .cards { - flex: 1; - display: flex; - flex-direction: column; - margin: 0 !important; - padding: 0 !important; - - .card .meta > a.milestone { - color: #999999; - } -} - -.board-column > .divider { - margin: 5px 0; -} - -.board-column:first-child { - margin-left: auto !important; -} - -.board-column:last-child { - margin-right: auto !important; -} - -.board-card { - margin: 3px !important; - width: auto !important; - background-color: #fff; - border-radius: 5px; - cursor: pointer; -} - -.board-card .header { - font-size: 1.1em !important; -} - -.board-card .content { - padding: 8px 8px 5px !important; -} - -.board-card .extra.content { - padding: 5px 8px !important; -} - td.blob-excerpt { background-color: #fafafa; } diff --git a/web_src/less/features/projects.less b/web_src/less/features/projects.less new file mode 100644 index 000000000000..238d0db6c284 --- /dev/null +++ b/web_src/less/features/projects.less @@ -0,0 +1,77 @@ +.board { + display: flex; + flex-direction: row; + flex-wrap: nowrap; + overflow-x: auto; + margin: 0 .5em; +} + +.board-column { + background-color: var(--color-project-board-bg) !important; + border: 1px solid var(--color-secondary) !important; + margin: 0 .5rem !important; + padding: .5rem !important; + width: 320px; + height: 60vh; + overflow-y: scroll; + flex: 0 0 auto; + overflow: visible; + display: flex; + flex-direction: column; +} + +.board-column-header { + display: flex; + justify-content: space-between; +} + +.board-label { + background: none !important; + line-height: 1.25 !important; +} + +.board-column > .cards { + flex: 1; + display: flex; + margin: 0 !important; + padding: 0 !important; + flex-wrap: nowrap !important; + flex-direction: column; +} + +.project-board-title { + word-break: break-word; +} + +.board-column > .divider { + margin: 5px 0; +} + +.board-column:first-child { + margin-left: auto !important; +} + +.board-column:last-child { + margin-right: auto !important; +} + +.board-card { + margin: 3px !important; + border-radius: 5px !important; + cursor: move; + width: calc(100% - 6px) !important; + padding: .5rem !important; +} + +.board-card .header { + font-size: 16px !important; +} + +.card-ghost { + border-style: dashed !important; + background: none !important; +} + +.card-ghost * { + opacity: 0; +} diff --git a/web_src/less/index.less b/web_src/less/index.less index f1ac49a5136b..c125ccac318d 100644 --- a/web_src/less/index.less +++ b/web_src/less/index.less @@ -8,6 +8,7 @@ @import "./features/heatmap.less"; @import "./features/imagediff.less"; @import "./features/codeeditor.less"; +@import "./features/projects.less"; @import "./markdown/mermaid.less"; @import "./chroma/base.less"; diff --git a/web_src/less/themes/theme-arc-green.less b/web_src/less/themes/theme-arc-green.less index cd381973c578..7c084284d105 100644 --- a/web_src/less/themes/theme-arc-green.less +++ b/web_src/less/themes/theme-arc-green.less @@ -107,6 +107,7 @@ --color-expand-button: #3c404d; --color-placeholder-text: #6a737d; --color-editor-line-highlight: var(--color-primary-light-5); + --color-project-board-bg: var(--color-secondary-light-2); } .ui.horizontal.segments > .segment { @@ -690,10 +691,6 @@ footer .container .links > * { border-color: #383c4a; } -.board-column { - background-color: rgba(0, 0, 0, .2) !important; -} - .tribute-container { box-shadow: 0 .25rem .5rem rgba(0, 0, 0, .6); } From 81d9bb783e7604dac894ec5889672b6e29311647 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Apr 2021 17:30:36 +0200 Subject: [PATCH 2/3] fix squashed cards on small view area --- web_src/less/features/projects.less | 1 + 1 file changed, 1 insertion(+) diff --git a/web_src/less/features/projects.less b/web_src/less/features/projects.less index 238d0db6c284..5a3fb8079cd3 100644 --- a/web_src/less/features/projects.less +++ b/web_src/less/features/projects.less @@ -61,6 +61,7 @@ cursor: move; width: calc(100% - 6px) !important; padding: .5rem !important; + min-height: auto !important; } .board-card .header { From e51585a067872b270e7f7cdf4530202fb9be8b63 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Apr 2021 18:32:09 +0200 Subject: [PATCH 3/3] more css fixes, add second row from issue list --- templates/repo/projects/view.tmpl | 28 ++++++++++++++++++++++------ web_src/less/features/projects.less | 9 +++++++-- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 802571293c65..59939af6b936 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -177,20 +177,36 @@ {{end}} {{end}} - #{{.Index}} {{.Title}} + + {{.Title}} + +
+
+ + #{{.Index}} + {{ $timeStr := TimeSinceUnix .GetLastEventTimestamp $.Lang }} + {{if .OriginalAuthor }} + {{$.i18n.Tr .GetLastEventLabelFake $timeStr .OriginalAuthor | Safe}} + {{else if gt .Poster.ID 0}} + {{$.i18n.Tr .GetLastEventLabel $timeStr .Poster.HomeLink (.Poster.GetDisplayName | Escape) | Safe}} + {{else}} + {{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName | Escape) | Safe}} + {{end}} +
{{- if .MilestoneID }} -
+
- {{svg "octicon-milestone" 16 "mr-2"}}{{ .Milestone.Name }} + {{svg "octicon-milestone" 16 "mr-2 vm"}} + {{ .Milestone.Name }}
{{- end }} {{- range index $.LinkedPRs .ID }} -
+
- {{svg "octicon-git-merge"}} - {{ .Title}} (#{{ .Index }}) + {{svg "octicon-git-merge" 16 "mr-2 vm"}} + {{ .Title}} #{{.Index}}
{{- end }} diff --git a/web_src/less/features/projects.less b/web_src/less/features/projects.less index 5a3fb8079cd3..f9d97a208696 100644 --- a/web_src/less/features/projects.less +++ b/web_src/less/features/projects.less @@ -56,15 +56,20 @@ } .board-card { - margin: 3px !important; + margin: 4px 2px !important; border-radius: 5px !important; cursor: move; - width: calc(100% - 6px) !important; + width: calc(100% - 4px) !important; padding: .5rem !important; min-height: auto !important; } +.board-card .meta * { + margin-right: 0 !important; +} + .board-card .header { + margin-top: 0 !important; font-size: 16px !important; }