Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that ctx.Written is checked after issues(...) calls #15797

Merged
merged 1 commit into from May 9, 2021
Merged

Ensure that ctx.Written is checked after issues(...) calls #15797

merged 1 commit into from May 9, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 8, 2021

Fix issue noted in #15783

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Ensure that ctx.Written is checked after issues(...) calls
3a62d97 
Fix issue noted in go-gitea#15783

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.0 milestone May 8, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15797 (3a62d97) into main (864e656) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15797      +/-   ##
==========================================
- Coverage   43.98%   43.89%   -0.10%     
==========================================
  Files         678      678              
  Lines       82022    82024       +2     
==========================================
- Hits        36079    36002      -77     
- Misses      40067    40161      +94     
+ Partials     5876     5861      -15
Impacted Files Coverage Δ
routers/repo/issue.go 38.28% <0.00%> (-0.05%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/notification/mail/mail.go 33.67% <0.00%> (-8.17%) ⬇️
models/issue_comment.go 45.54% <0.00%> (-7.05%) ⬇️
modules/notification/ui/ui.go 58.97% <0.00%> (-6.84%) ⬇️
modules/git/commit.go 52.15% <0.00%> (-4.32%) ⬇️
modules/queue/manager.go 61.36% <0.00%> (-2.85%) ⬇️
modules/notification/base/null.go 76.31% <0.00%> (-2.64%) ⬇️
modules/notification/notification.go 85.12% <0.00%> (-2.48%) ⬇️
services/pull/pull.go 42.92% <0.00%> (-0.92%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 864e656...3a62d97. Read the comment docs.

a1012112796
a1012112796 approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021
@lunny lunny merged commit a69fb52 into go-gitea:main May 9, 2021
@lunny
Copy link
Member

lunny commented May 9, 2021

Please send backport

@zeripath zeripath deleted the fix-15783-servererror-written branch May 9, 2021 06:18
6543 pushed a commit to 6543-forks/gitea that referenced this pull request May 9, 2021
@zeripath @6543
Ensure that ctx.Written is checked after issues(...) calls (go-gitea#…
f320b52 
…15797)

Fix issue noted in go-gitea#15783

Signed-off-by: Andrew Thornton <art27@cantab.net>
@6543 6543 mentioned this pull request May 9, 2021
Merged
@6543
Copy link
Member

6543 commented May 9, 2021

-> #15798

@6543 6543 added the backport/done All backports for this PR have been created label May 9, 2021
zeripath added a commit that referenced this pull request May 9, 2021
@6543 @zeripath
Ensure that ctx.Written is checked after issues(...) calls (#15797) (#…
af11549 
…15798)

Fix issue noted in #15783

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Ensure that ctx.Written is checked after issues(...) calls (go-gitea#…
8c0efdc 
…15797)

Fix issue noted in go-gitea#15783

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zeripath @codecov-commenter @lunny @6543 @a1012112796 @GiteaBot