Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (8)
@6543 6543 Aug 12, 2021
```suggestion Description: "Test repository for testing migration from OneDev to gitea", ```
Outdated
modules/migrations/onedev_test.go
6543
6543
@zeripath zeripath Aug 10, 2021
You must set the ctx on the request otherwise it is not cancellable. ```suggestion req, err := http.NewRequestWithContext(d.ctx, "GET", u.String(), nil) ```
Outdated
modules/migrations/onedev.go
@zeripath zeripath Aug 10, 2021
How about: ```go type BasicIssueContext int64 // LocalID gets the local id. func (c BasicIssueContext) LocalID() int64 { return int64(c) } // ForeignID gets the foreign id. func (c BasicIssueContext) ForeignID() int64 { return int64(c) } ```
Outdated
modules/migrations/base/issue.go
@lunny lunny Aug 10, 2021
This may breaks something on migrating repository into files. 🤔
modules/migrations/base/pullrequest.go
KN4CK3R
KN4CK3R
@6543 6543 Aug 9, 2021
is there a **public onedev** instance we could create a org *gitea* and put a **test repo to migrate** like we did with github and gitlab? -> tld: `opendev_test.go` ;)
modules/migrations/onedev.go
6543 KN4CK3R
6543 and KN4CK3R
@6543 6543 Aug 9, 2021
looks valid but unrelated - we can leave it but a backport would be nice
modules/migrations/gitea_uploader.go
6543 zeripath
6543 and zeripath
@zeripath zeripath Jul 20, 2021
This feels questionable... I would argue that there has to be something common to all of these forges and these requests. At the least a `foreign_issue` must map to a gitea `issue and that mapping is at its simplest: Gitea index => foreign URL That mapping should always have at least a function to returna gitea ID and a function to return the foreign id which should be the URL. Other functions could be done. But that essentially defines a basic interface that you should be able to rely on here.
Outdated
modules/migrations/base/downloader.go
6543 KN4CK3R
6543 and KN4CK3R
@techknowlogick techknowlogick Jul 7, 2021
tiny nit that this creates a onedev downloader, rather than a gogs one.
Outdated
modules/migrations/onedev.go