Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add link to vscode to repo header #16664

Merged
merged 4 commits into from Aug 12, 2021
Merged

add link to vscode to repo header #16664

merged 4 commits into from Aug 12, 2021

Conversation

a1012112796
Copy link
Member

example:
log2

may be can add more ide, But I don't know the link format, feel free to add it if you like.

@a1012112796
add link to vscode to repo header
4605e1a 
Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Aug 11, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 11, 2021
@lunny lunny added this to the 1.16.0 milestone Aug 11, 2021
@lunny
Copy link
Member

lunny commented Aug 11, 2021

It's not aligned.
image

@lafriks
Copy link
Member

lafriks commented Aug 11, 2021

UI part looks odd. @silverwind maybe you have recommendations?

@lafriks
Copy link
Member

lafriks commented Aug 11, 2021

Maybe it could be added between copy & download buttons after repo git link?

@6543
Copy link
Member

6543 commented Aug 11, 2021

Add it as option to download menue?!?

@silverwind
Copy link
Member

silverwind commented Aug 11, 2021 •
edited

I feel we have too many buttons there already, so moving it to the download menu might be good to save space, but that menu might need to be renamed, so it has:

  • Open in VS Code
  • Download ZIP
  • Download TAR.GZ

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 12, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 12, 2021
@6543 6543 merged commit ca13e1d into go-gitea:main Aug 12, 2021
@a1012112796 a1012112796 deleted the a1012/ui_vsc_link branch August 12, 2021 12:35
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@a1012112796 @codecov-commenter @lunny @lafriks @6543 @silverwind @KN4CK3R @GiteaBot