Fix migration svg color

[KN4CK3R]

The SVGs on the migration page inherit the current text color which created wrong icons.

Before:

After:

Possible alternative: color: unset;
@silverwind I don't know what is better in this case. unset works nice with themes but is still the wrong color.

[silverwind]

How does one get this icon to show? I don't see it on https://try.gitea.io/repo/migrate.

[KN4CK3R]

It's in #16356. The original svg contains fill="#000000" but make svg strips the black fill because it is the default color.

[silverwind]

I see two options given that this icon needs to change color on dark themes:

.migrate .card {
  color: var(--color-text);
}

or specifically override the icon to a different color:

svg.gitea-onedev {
  fill: var(--color-secondary-dark-11);
}

[KN4CK3R]

Does it really "need" to change color on dark themes? If the icon is black it should be black with all themes or not? We do not adjust the git icon on orange themes.
An alternative would be to use fill="#000001" in the icon which does not get stripped.

[silverwind]

Does it really "need" to change color on dark themes

I prefer to change it because it gives more contrast, even if it's not a original color anymore.

An alternative would be to use fill="#1" in the icon which does not get stripped.

I'm sure there is a svgo plugin to disable somewhere.

[codecov-commenter]

Codecov Report

Merging #16715 (f10fd53) into main (274aeb3) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16715      +/-   ##
==========================================
- Coverage   45.40%   45.36%   -0.04%     
==========================================
  Files         758      758              
  Lines       85306    85381      +75     
==========================================
+ Hits        38732    38733       +1     
- Misses      40300    40366      +66     
- Partials     6274     6282       +8     

Impacted Files	Coverage Δ
modules/queue/manager.go	65.34% <0.00%> (-2.85%)	⬇️
modules/queue/workerpool.go	53.05% <0.00%> (-2.68%)	⬇️
modules/log/file.go	73.60% <0.00%> (-1.61%)	⬇️
modules/migrations/gitea_uploader.go	6.77% <0.00%> (-0.63%)	⬇️
models/models.go	52.88% <0.00%> (-0.54%)	⬇️
routers/api/v1/repo/pull.go	29.11% <0.00%> (-0.52%)	⬇️
services/pull/pull.go	41.78% <0.00%> (-0.41%)	⬇️
modules/migrations/gitlab.go	0.99% <0.00%> (+<0.01%)	⬆️
modules/migrations/gogs.go	2.36% <0.00%> (+0.01%)	⬆️
modules/setting/setting.go	49.90% <0.00%> (+0.09%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274aeb3...f10fd53. Read the comment docs.