Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating draft releases while keeping them as draft #169

Merged
merged 1 commit into from Nov 14, 2016

Conversation

5 participants
@strk
Copy link
Member

commented Nov 14, 2016

Closes #162

@strk strk referenced this pull request Nov 14, 2016

Closed

Can't save Release draft as draft #162

1 of 3 tasks complete
routers/repo/release.go Outdated
@@ -247,6 +247,7 @@ func EditRelease(ctx *context.Context) {
ctx.Data["title"] = rel.Title
ctx.Data["content"] = rel.Note
ctx.Data["prerelease"] = rel.IsPrerelease
ctx.Data["draft"] = rel.IsDraft

This comment has been minimized.

Copy link
@bkcsoft

bkcsoft Nov 14, 2016

Member

Should be ctx.Data["IsDraft"]

If you feel like it, you might as well fix the above ones as well. Though not related to this issue 🙂

This comment has been minimized.

Copy link
@strk

strk Nov 14, 2016

Author Member

I'd prefer keeping commits focused on what they address. There are also still ALL_UPPER_CASE constants in that file, but would rather not touch now. Can change the IsDraft though, being a new one.

This comment has been minimized.

Copy link
@strk

strk Nov 14, 2016

Author Member

Done, IsDraft is there

@bkcsoft

This comment has been minimized.

Copy link
Member

commented Nov 14, 2016

LGTM

@bkcsoft bkcsoft added this to the 1.0.0 milestone Nov 14, 2016

@strk strk force-pushed the strk:allow-update-draft-releases branch to cd33926 Nov 14, 2016

@thibaultmeyer

This comment has been minimized.

Copy link
Member

commented Nov 14, 2016

LGTM

@codecov-io

This comment has been minimized.

Copy link

commented Nov 14, 2016

Current coverage is 3.03% (diff: 100%)

Merging #169 into master will not change coverage

@@            master      #169   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20          

Powered by Codecov. Last update 81f227e...cd33926

@bkcsoft bkcsoft merged commit 07a0753 into go-gitea:master Nov 14, 2016

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@strk strk deleted the strk:allow-update-draft-releases branch Nov 15, 2016

@tboerger tboerger removed the lgtm/done label Nov 15, 2016

@tboerger tboerger added the lgtm/done label Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.