Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (8)
@zeripath zeripath Sep 14, 2021
This could do with some comments to explain what it's doing and why we're iterating over both sides.
Outdated
services/gitdiff/csv.go
zeripath richmahn
zeripath and Richard Mahn
@zeripath zeripath Sep 14, 2021
Similarly flip this to true and set it false if you get something
Outdated
services/gitdiff/csv.go
@zeripath zeripath Sep 14, 2021
Similarly flip this to true and set it false if you get something
Outdated
services/gitdiff/csv.go
@zeripath zeripath Sep 14, 2021
Probably better to set aIsUndefined := true and then only set it to false at line 193
Outdated
services/gitdiff/csv.go
@zeripath zeripath Sep 14, 2021
So if we get an NPE we fall down to line 37 where we guess a delimiter on an empty []byte and create a reader on the empty input?
Outdated
modules/csv/csv.go
richmahn
Richard Mahn
@zeripath zeripath Sep 14, 2021
I would worry that in this case the rd would be nil and we'd get an NPE below.
Outdated
modules/markup/csv/csv.go
zeripath richmahn
zeripath and Richard Mahn
@zeripath zeripath Sep 14, 2021
ioutil cannot return io.EOF
Outdated
modules/markup/csv/csv.go
@KN4CK3R KN4CK3R Sep 12, 2021
This may be wrong for other renderers. You could check in the csv renderer for `io.EOF` and treat it as no error.
Outdated
routers/web/repo/view.go
richmahn zeripath
Richard Mahn and zeripath