```suggestion Type string `xorm:"VARCHAR(16) INDEX UNIQUE(repo_foreign_type)"` ``` Current struct in `foreignreference.go` also uses 16.

This and the errors may be better placed in `/models/federation` or similiar. The goal is to make `/models` cleaner.

Is 8 enough? In fact, we can enumerate them now. `issue`, `pull_request`, `comment`, `review`, `review_comemnt`, `release`. Maybe 16 is better?

It's inconsistent with above code. See https://github.com/go-gitea/gitea/pull/18446/files#r804317877

So `LocalID` is pointing to issue's `ID` or issue's `Index`?

comment is necessary

Just left the first year is OK.

The `ForeignID` is string in database, but in code, it's `int64`, I think the type should be consistent.

If the `LocalID` is the `issue index`, it's better to be called `LocalIssueIndex`, we should avoid introducing ambiguous concepts as much as possible.

If I understand correctly, we only have one type: "issue" now? Should we use a constant for the `Type`?

As above.

The meaning of `ID` is quite confusing. In Gitea, `ID` means the primary key of a model, for example, IssueID is `issue`.`id` The `number` of an issue is called `index` in Gitea. Should we clarify these concepts? `GetLocalIssueIndex` is more clear if I understand correctly.

I have a feeling that we should put the code to a correct place, instead of using this big banner 😂

File name? Should be v210.go

```suggestion // v209 -> v210 ```