Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed .hide class #23208

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Fix missed .hide class #23208

merged 3 commits into from
Mar 2, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 1, 2023

#22950 removed hide class, and use gt-hidden
But there are some missed hide....

@yp05327 yp05327 changed the title change hide to gt-hidden Fix missed .hide class Mar 1, 2023
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Mar 1, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 1, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 1, 2023 •
edited
Loading

Thank you very much. The regexp I used to find the "hide" things was not strong enough at that moment.

ps: my plan was to replace these classes batch by batch in a few PRs (to make the replacement more accurate and to make the review easier), while at that time, some people asked to do everything in one PR without intermediate step .... the all-in-one PR seems not easy to maintain 😂

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2023
@yp05327 @wxiaoguang
Update templates/admin/user/new.tmpl
c2c7a9b 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@yp05327
Copy link
Contributor Author

yp05327 commented Mar 1, 2023

Thank you very much. The regexp I used to find the "hide" things was not strong enough at that moment.

ps: my plan was to replace these classes batch by batch in a few PRs (to make the replacement more accurate and to make the review easier), while at that time, some people asked do everything in one PR without intermediate step .... the all-in-one PR seems not easy to maintain 😂

@wxiaoguang
When I was going to add a user, I found that something changed.
Authentication Sign-In Name displayed in my form with required class, but I successed adding a user without input this Sign-in Name.
At first, I thought this was a bug, and removed required, but after that, I found that there was a hide class and it didn't work.

ps: my plan was to replace these classes batch by batch in a few PRs (to make the replacement more accurate and to make the review easier), while at that time, some people asked do everything in one PR without intermediate step .... the all-in-one PR seems not easy to maintain 😂

It is not easy to make an all-in-one PR unless it is necessary. In my opinion, Step-by-Step is better and easy to review.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 1, 2023
@lunny lunny merged commit 0945bf6 into go-gitea:main Mar 2, 2023
@GiteaBot GiteaBot mentioned this pull request Mar 2, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 2, 2023
@yp05327 @wxiaoguang @GiteaBot
Fix missed .hide class (go-gitea#23208)
39e45f9 
go-gitea#22950 removed `hide` class, and
use `gt-hidden`
But there are some missed `hide`....

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 2, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 2, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a28152f 
* giteaofficial/main:
  Fix commit retrieval by tag (go-gitea#21804)
  Fix missed `.hide` class (go-gitea#23208)
  [skip ci] Updated translations via Crowdin
  Add loading yaml label template files (go-gitea#22976)
  Allow `<video>` in MarkDown (go-gitea#22892)
  Pull Requests: add button to compare force pushed commits (go-gitea#22857)
  Do not create commit graph for temporary repos (go-gitea#23219)
  Use the correct selector to hide the checkmark of selected labels on clear (go-gitea#23224)
  Order pull request conflict checking by recently updated, for each push (go-gitea#23220)
  Fix incorrect checkbox behaviors in the dashboard repolist's filter (go-gitea#23147)
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 2, 2023
jolheiser pushed a commit that referenced this pull request Mar 2, 2023
@GiteaBot @yp05327
Fix missed .hide class (#23208) (#23237)
790a79b 
Backport #23208

#22950 removed `hide` class, and
use `gt-hidden`
But there are some missed `hide`....

Co-authored-by: yp05327 <576951401@qq.com>
@yp05327 yp05327 deleted the fix-hide branch March 13, 2023 01:06
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@yp05327 @wxiaoguang @lafriks @delvh @lunny @techknowlogick @GiteaBot @jolheiser