Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when parsing an invalid workflow file #23972

Merged
merged 5 commits into from Apr 7, 2023
Merged

Do not crash when parsing an invalid workflow file #23972

merged 5 commits into from Apr 7, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Apr 7, 2023

@wolfogre wolfogre added dependencies topic/gitea-actions related to the actions of Gitea outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 7, 2023
@wolfogre wolfogre added this to the 1.20.0 milestone Apr 7, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2023
@delvh delvh added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 7, 2023
@delvh delvh changed the title Avoid fatal in act/pkg/model Do not crash when parsing an invalid workflow file Apr 7, 2023
@delvh delvh enabled auto-merge (squash) April 7, 2023 10:13
@delvh
Copy link
Member

delvh commented Apr 7, 2023

🎺 🤖

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 7, 2023
@lunny lunny disabled auto-merge April 7, 2023 12:11
@lunny lunny merged commit ecf34fc into go-gitea:main Apr 7, 2023
1 of 2 checks passed
@GiteaBot GiteaBot mentioned this pull request Apr 7, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 7, 2023
@wolfogre
Do not crash when parsing an invalid workflow file (go-gitea#23972)
4047790 
Fix go-gitea#23658.

Related to https://gitea.com/gitea/act/pulls/39
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 7, 2023
@lunny lunny removed backport/done All backports for this PR have been created reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 7, 2023
@delvh delvh added backport/done All backports for this PR have been created and removed reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled labels Apr 7, 2023
delvh pushed a commit that referenced this pull request Apr 7, 2023
@GiteaBot @wolfogre
Do not crash when parsing an invalid workflow file (#23972) (#23976)
f317186 
Backport #23972 by @wolfogre

Fix #23658.

Related to https://gitea.com/gitea/act/pulls/39

Co-authored-by: Jason Song <i@wolfogre.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/gitea-actions related to the actions of Gitea
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

actions: crash if action yaml cannot be parsed
4 participants
@wolfogre @delvh @lunny @GiteaBot