Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip known flaky queue tests on CI environment #24419

Merged
merged 2 commits into from Apr 29, 2023
Merged

Skip known flaky queue tests on CI environment #24419

merged 2 commits into from Apr 29, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 29, 2023 •
edited

Random CI failures are annoying. It's better to just skip the affected tests so maintainers can use their valuable time for more productive topics.

Related: #23608
Related: #23977
Related: #18703

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2023
@silverwind silverwind changed the title Skip known flaky tests Skip known flaky queue tests Apr 29, 2023
@silverwind silverwind changed the title Skip known flaky queue tests Skip known flaky queue tests on CI environment Apr 29, 2023
delvh
delvh approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fixes"

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2023
@silverwind
Copy link
Member Author

Could keep the issues open so they won't be completely forgotten.

@silverwind
Copy link
Member Author

Ok, edited OP so they will keep open. I'm not sure if #23608 and #23977 are the same issue, so keeping both open even when they refer to the same test.

@wxiaoguang
Copy link
Contributor

I would propose to rewrite the queue code.

@silverwind
Copy link
Member Author

silverwind commented Apr 29, 2023 •
edited

Sure, fixing the bug (whether it is in test or code) is always better, but I think at some point our patience regarding waiting on such a fix must end. 😆

Issue is these bugs don't reproduce locally, for me at least, making debugging them hard.

@wxiaoguang
Copy link
Contributor

Sure, fixing the bug (whether it is in test or code) is always better, but I think at some point our patience regarding waiting on such a fix must end. 😆

Issue is these bugs don't reproduce locally, for me at least, making debugging them hard.

If enough people would approve, I can rewrite it (it won't be too long IMO)

@silverwind
Copy link
Member Author

silverwind commented Apr 29, 2023 •
edited

Let's wait with this PR then, maybe a week max.

@silverwind silverwind added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Apr 29, 2023
@wxiaoguang
Copy link
Contributor

Let's wait with this PR then, maybe a week max.

I think it's also good to take this one, to save merger's time. It doesn't harm anything IMO.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2023
@silverwind silverwind merged commit fc62992 into go-gitea:main Apr 29, 2023
2 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 29, 2023
@silverwind silverwind deleted the skip-flaky branch April 29, 2023 09:53
@silverwind silverwind added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 and removed status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Apr 29, 2023
@silverwind
Copy link
Member Author

Backporting as well because issue shows up on 1.19 as well of cource.

@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19. @silverwind, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 30, 2023
@silverwind silverwind mentioned this pull request Apr 30, 2023
Merged
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label Apr 30, 2023
silverwind added a commit that referenced this pull request Apr 30, 2023
@silverwind
Skip known flaky queue tests on CI environment (#24443)
f1a0b64 
Backport of #24419 to 1.19.
@silverwind silverwind mentioned this pull request May 2, 2023
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @GiteaBot @delvh @yardenshoham