Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.20 for next release #24859

Merged
merged 2 commits into from
May 22, 2023
Merged

Use Go 1.20 for next release #24859

merged 2 commits into from
May 22, 2023

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2023
@wxiaoguang wxiaoguang added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 22, 2023
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 22, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2023
@silverwind
Copy link
Member

silverwind commented May 22, 2023 •
edited
Loading

Check if make tidy introduces any changes. Though I guess CI would fail if it would.

@wxiaoguang
Copy link
Contributor Author

Quote from #24726 (comment)

silverwind: With current policy of last two supported Go versions, we can only require Go 1.20 when Go 1.21 is out, which is in around 3 months. Maybe we should change that policy though.

wxiaoguang: Hmm, yes, the problem is that if we still use Golang 1.19, then after Golang 1.21 gets released, Golang 1.19 won't get any updates. So, I think it's good to make Gitea's release can use active Golang version in its lifecycle (it's not a must if most people prefer to keep Gitea 1.20 on Golang 1.19)
I also remembered that somewhere mentions that "Gitea supports the last two go versions", but I can not find it now .... where is it? 🤣 Has it already been removed?

@wxiaoguang
Copy link
Contributor Author

Check if make tidy introduces any changes. Though I guess CI would fail if it would.

I have done so before commit. And CI passes.

@silverwind
Copy link
Member

silverwind commented May 22, 2023 •
edited
Loading

Re #24726 (comment):

README says

make backend which requires Go Stable, required version is defined in go.mod.

"Go Stable" is equivalent to "last two versions", but our go.mod will be stricter with this change.

image

@wxiaoguang
Copy link
Contributor Author

Oh yes, that's also written by me (#19918), the reason is the same:

Use Golang 1.18 (as minimal requirement) for Gitea 1.17 release, make sure the Golang version is still actively supported during Gitea 1.17 lifecycle.

image

So, theoretically speaking, more stricter go.mod doesn't violate this rule.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2023
silverwind
silverwind approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok if there is no easy way to get it compatible with 1.19.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 22, 2023
@silverwind silverwind enabled auto-merge (squash) May 22, 2023 16:04
@silverwind silverwind disabled auto-merge May 22, 2023 16:04
@silverwind silverwind enabled auto-merge (squash) May 22, 2023 16:04
@silverwind silverwind merged commit 81ce271 into go-gitea:main May 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 22, 2023
@wxiaoguang wxiaoguang deleted the fix-version branch May 22, 2023 16:30
@KN4CK3R KN4CK3R mentioned this pull request May 22, 2023
Open
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 23, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
f0522e1 
* upstream/main:
  Fix install page context, make the install page tests really test (go-gitea#24858)
  Add validations.required check to dropdown field (go-gitea#24849)
  Use Go 1.20 for next release (go-gitea#24859)
  Add gitea manager reload-templates command (go-gitea#24843)
  Remove `In your repositories` link in milestones dashboard (go-gitea#24853)
  Fix 500 error when select `No assignee` filter in issue list page (go-gitea#24854)
  Add IsErrRepoFilesAlreadyExist check when fork repo (go-gitea#24678)
  Fix missing yes/no in delete time log modal (go-gitea#24851)
  Fix document and improve comment (go-gitea#24844)

# Conflicts:
#	web_src/css/base.css
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wxiaoguang @silverwind @lunny @KN4CK3R @yardenshoham @delvh @GiteaBot