From 76db7aebf08edfcab93d89eaa86d01985984651c Mon Sep 17 00:00:00 2001 From: Sebastian Sauer Date: Thu, 3 Aug 2023 21:15:48 +0200 Subject: [PATCH 1/2] Use yellow if an approved review is stale --- models/issues/review.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/models/issues/review.go b/models/issues/review.go index b2736044fce0b..fcba9b8c7e1d2 100644 --- a/models/issues/review.go +++ b/models/issues/review.go @@ -192,7 +192,11 @@ func (r *Review) LoadAttributes(ctx context.Context) (err error) { func (r *Review) HTMLTypeColorName() string { switch r.Type { case ReviewTypeApprove: - return "green" + if r.Stale { + return "yellow" + } else { + return "green" + } case ReviewTypeComment: return "grey" case ReviewTypeReject: From 6db87e3701159b09f502a586b8e9ecc50231e631 Mon Sep 17 00:00:00 2001 From: Sebastian Sauer Date: Thu, 3 Aug 2023 21:49:09 +0200 Subject: [PATCH 2/2] Fix lint --- models/issues/review.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/models/issues/review.go b/models/issues/review.go index fcba9b8c7e1d2..cae3ef1d395e5 100644 --- a/models/issues/review.go +++ b/models/issues/review.go @@ -194,9 +194,8 @@ func (r *Review) HTMLTypeColorName() string { case ReviewTypeApprove: if r.Stale { return "yellow" - } else { - return "green" } + return "green" case ReviewTypeComment: return "grey" case ReviewTypeReject: