GPG key email verification no longer case sensitive (#2661) #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
Codecov Report
@@ Coverage Diff @@
## master #2663 +/- ##
==========================================
- Coverage 27.13% 27.13% -0.01%
==========================================
Files 86 86
Lines 17061 17062 +1
==========================================
Hits 4629 4629
- Misses 11754 11755 +1
Partials 678 678
Continue to review full report at Codecov.
|
|
LGTM |
sapk
reviewed
Oct 6, 2017
models/gpg_key.go
Outdated
| @@ -402,7 +402,7 @@ func ParseCommitWithSignature(c *git.Commit) *CommitVerification { | |||
| //Pre-check (& optimization) that emails attached to key can be attached to the commiter email and can validate | |||
| canValidate := false | |||
| for _, e := range k.Emails { | |||
| if e.IsActivated && e.Email == c.Committer.Email { | |||
| if e.IsActivated && strings.ToLower(e.Email) == strings.ToLower(c.Committer.Email) { | |||
There was a problem hiding this comment.
For little performance improvement, strings.ToLower(c.Committer.Email) could be cached inside a var like lowerCommiterEmail := strings.ToLower(c.Committer.Email) before for _, k := range keys {
Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
sapk
approved these changes
Oct 6, 2017
|
LGTM. Thanks for doing it. |
sapk
pushed a commit
to sapk-fork/gitea
that referenced
this pull request
Oct 26, 2017
…o-gitea#2663) * GPG key email verification no longer case sensitive (go-gitea#2661) * case insensitive GPG key email verification now cached (go-gitea#2661) Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
lunny
pushed a commit
that referenced
this pull request
Oct 27, 2017
* Only check at least one email gpg key (#2266) * Only require one email (possibly not yet validated) * Update message error and check validation of commit * Add integrations tests * Complete integration for import * Add pre-check/optimization * Add some test (not finished) * Finish * Fix fixtures * Fix typo * Don't guess key ID * Make repo private to no interfere with other tests (#2467) * GPG key email verification no longer case sensitive (#2661) (#2663) * GPG key email verification no longer case sensitive (#2661) * case insensitive GPG key email verification now cached (#2661) Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
surround every mail in https://github.com/go-gitea/gitea/blob/master/models/gpg_key.go#L405
with strings.ToLower(email)
Fixes #2661