Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (8)
@delvh delvh Feb 27, 2024
Why not use the normal `newJSONRequest`?
services/webhook/matrix.go
oliverpool delvh
oliverpool and delvh
@delvh delvh Feb 27, 2024
```suggestion log.Info("HTTP Method for %s webhook %s [ID: %d] is not set, defaulting to POST", w.Type, w.URL, w.ID) ```
Outdated
services/webhook/deliver.go
@delvh delvh Feb 26, 2024
Wouldn't it make sense to use ```suggestion PayloadVersion int `xorm:"DEFAULT 1"` ``` here?
Outdated
models/migrations/v1_22/v287.go
delvh lunny
oliverpool
delvh, Lunny Xiao, and oliverpool
@silverwind silverwind Feb 13, 2024
```suggestion <span class="text orange">{{svg "octicon-stopwatch"}}</span> ```
Outdated
templates/repo/settings/webhook/history.tmpl
@jolheiser jolheiser Feb 13, 2024
```suggestion URL string `json:"url"` ```
Outdated
services/webhook/packagist.go
@KN4CK3R KN4CK3R Feb 12, 2024
`Version` may not be a good name because this name is used by other models to enforce a write lock in a transaction. Maybe use `PayloadVersion` and move it below `PayloadContent`?
Outdated
models/webhook/hooktask.go
oliverpool
oliverpool
@KN4CK3R KN4CK3R Feb 12, 2024
```suggestion ``` Only the new field is needed.
Outdated
models/migrations/v1_22/v287.go
oliverpool
oliverpool
@oliverpool oliverpool Feb 12, 2024
The `lint-backend` does not like the import of `code.gitea.io/gitea/services/cron` (which import `code.gitea.io/gitea/models`). Should I drop it?
Outdated
models/migrations/v1_22/v287.go
oliverpool delvh
oliverpool and delvh