Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expandable commit bodies #2980
UPDATE: Here is how it looks right now:
I've taken some time to try to work on some kind of solution to the expandable commit message bodies that was talked about in #2939 and #2944, but trying to make it work like it does on GitHub and GitLab. It is however a very rough work in progress as I've never programmed in Go before nor have I much experience with JQuery.
There are several issues with this right now:
I'd like a helping hand with this to figure out how to best solve it, as I'm not a Go programmer.
I've managed to make it place the commit bodies somewhat properly into the HTML now, my biggest hurdle now is getting the cells to stop moving when you expand the commit bodies. The image below shows what happens, when you press the [...] button it moves the commit time, avatar, username and SHA-code into the middle of the cell, which makes the whole layout jump around when you press it.
How would I stop that from happening?
Also, where do we display the commit messages in Gitea? I need to update all the places where we show the commit message to this new format.
@lafriks yeah, I haven't added them yet. I'll do it once I'm happy with them.
I've updated the code with the suggestions from you guys, but I also changed the
edit: I'm not sure what the error is now, it suggests adding a newline to the CSS as far as I can see but that didn't work.
@@ Coverage Diff @@ ## master #2980 +/- ## ========================================== - Coverage 33.03% 32.98% -0.06% ========================================== Files 270 270 Lines 39534 39549 +15 ========================================== - Hits 13061 13044 -17 - Misses 24617 24650 +33 + Partials 1856 1855 -1