Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Mar 18, 2024

Fixes: #29853
Fixes: #29870

With this, it's no longer possible to drop something onto the first column, which prevents the 500 error from happening. In the future we should remove the restriction and allow dragging from and to column 0.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2024
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix will become obsolete after #29874

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2024
@silverwind
Copy link
Member Author

silverwind commented Mar 18, 2024

Should we take it and you revert it in your PR afterwards? I don't really care much about the issue. It's been present for a long term and no one complained apparently.

@denyskon
Copy link
Member

My PR is ready for review and should be easy to merge, so closing this :)

@denyskon denyskon closed this Mar 18, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/js

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving project panels results in 500 GetProjectBoard: project board does not exist

3 participants