Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (7)
@wxiaoguang wxiaoguang Jun 13, 2024
Every `const` here is only used once for constructing the "map" I think all of these `const` should be removed, and just fill the values into the map directly.
models/repo/search.go
6543
6543
@delvh delvh Jun 12, 2024
If it wasn't already present in the original code, I'd propose dropping the `Search-` prefix in this PR. It only confuses without bringing any additional value. As it exists already, I'll see that I open another refactoring PR once this one was merged.
models/repo/search.go
6543
6543
@delvh delvh Jun 12, 2024
One potential problem with this approach: `ASc` or `ASC` results in the default sorting, even if a valid sorting is given We should probably lowercase the order first
routers/web/explore/repo.go
6543
6543
@lunny lunny Jun 11, 2024
Why not keep them here?
models/db/search.go
6543
6543
@6543 6543 May 6, 2024
this will affect the explore page similar as #30784 too
models/repo/search.go
6543 lunny
6543 and Lunny Xiao
@6543 6543 May 6, 2024
extend options to let api be on pair with webui options
Outdated
models/repo/search.go
@6543 6543 May 6, 2024
this make it easyer to match human keywords with api options ... but if prefered I could also use the const directly ...
models/repo/search.go
wxiaoguang
wxiaoguang