Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo links #3093

Merged
merged 1 commit into from Dec 5, 2017

Conversation

5 participants
@ethantkoenig
Copy link
Member

ethantkoenig commented Dec 5, 2017

Fixes incorrect links in the repository listing of a user profile, as described #3035.

This PR does not address the other points raised in #3035, e.g.

  • whether it makes sense to have "Show more repos" link to a user's profile page
  • whether it makes sense to initially show only a user's repos on their profile page, but include collaborative repos when searching on the profile page

Therefore, we probably should not close #3035 if/when this PR merged.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #3093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3093   +/-   ##
=======================================
  Coverage   33.26%   33.26%           
=======================================
  Files         273      273           
  Lines       39954    39954           
=======================================
  Hits        13290    13290           
+ Misses      24768    24763    -5     
- Partials     1896     1901    +5
Impacted Files Coverage Δ
models/repo_indexer.go 47.52% <0%> (-1.49%) ⬇️
models/repo.go 38.15% <0%> (-0.19%) ⬇️
models/issue.go 45.05% <0%> (+0.19%) ⬆️
models/error.go 32.72% <0%> (+0.61%) ⬆️
models/issue_indexer.go 67.53% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2738eff...c8477b4. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 label Dec 5, 2017

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Dec 5, 2017

LGTM

@tboerger tboerger added lgtm/need 1 and removed lgtm/need 2 labels Dec 5, 2017

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Dec 5, 2017

LGTM

@tboerger tboerger added lgtm/done and removed lgtm/need 1 labels Dec 5, 2017

@lunny lunny added this to the 1.4.0 milestone Dec 5, 2017

@lunny lunny merged commit 03eb47b into go-gitea:master Dec 5, 2017

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@ethantkoenig ethantkoenig deleted the ethantkoenig:fix/user_repos branch Dec 5, 2017

lafriks added a commit to lafriks/gitea that referenced this pull request Dec 12, 2017

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Dec 12, 2017

Also fix #3148

lafriks added a commit that referenced this pull request Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.