Fix the possible migration failure on 286 with postgres 16 #31209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
modifies/go
|
Wonder why tests didn't catch that. Do we have tests that execute all migrations against all DBs? |
silverwind
approved these changes
Jun 1, 2024
GiteaBot
added
lgtm/need 1
We already have a test for v286 migration and my local test also cannot find it. Maybe it's related to some postgres arguments. |
|
Okay, strange issue. But this change is good to have in any case and we should have spotted this during review. |
lafriks
approved these changes
Jun 1, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 2, 2024
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 3, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix overflow in issue card (go-gitea#31203) Fix agit checkout command line hint & fix ShowMergeInstructions checking (go-gitea#31219) Fix the possible migration failure on 286 with postgres 16 (go-gitea#31209) Only update poster in issue/comment list if it has been loaded (go-gitea#31216) Return an empty string when a repo has no avatar in the repo API (go-gitea#31187) Split sanitizer functions and fine-tune some tests (go-gitea#31192) Performance improvements for pull request list API (go-gitea#30490) Fix URL In Gitea Actions Badge Docs (go-gitea#31191)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #31205