Jump to conversation
Unresolved conversations (1)
@lunny lunny Nov 21, 2024
Looks like these changes are duplicated as line 193 `issue_service.ReviewRequestNotify`
services/pull/pull.go
Resolved conversations (4)
@wxiaoguang wxiaoguang Nov 3, 2024
I have resolved some conflicts. But here I haven't read it carefully. This PR ever changed it to `initListSubmits('select-reviewers-modify', 'reviewers');` Was it done intentionally? If yes, what's the reason behind it?
Outdated
web_src/js/features/repo-issue-sidebar.ts
wxiaoguang CalK16
wxiaoguang and Calvin K
@wxiaoguang wxiaoguang Nov 3, 2024
Still some `gt-xxx` classes?
Outdated
web_src/js/features/repo-legacy.ts
@wxiaoguang wxiaoguang Nov 3, 2024
What is `select-reviewers-modify`? Why it was changed to `'reviewers'`? (see below: https://github.com/go-gitea/gitea/pull/32403#discussion_r1826957271)
Outdated
web_src/js/features/repo-legacy.ts
@lunny lunny Nov 2, 2024
```suggestion if isPull && len(form.ReviewerIDs) > 0 { ```
Outdated
routers/web/repo/issue.go