New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more additional template snippets #3286

Merged
merged 1 commit into from Jan 2, 2018

Conversation

5 participants
@tboerger
Member

tboerger commented Jan 2, 2018

That way we are able to add additional custom temmplate content more easily. A good example is https://try.gitea.io where we place a notice at the top, currently we are overwriting the header template and we are lacking changes if the template gets updated.

@tboerger tboerger added this to the 1.4.0 milestone Jan 2, 2018

@lafriks

This comment has been minimized.

Member

lafriks commented Jan 2, 2018

LGTM

@tboerger tboerger added the lgtm/need 1 label Jan 2, 2018

@@ -130,9 +130,13 @@
{{template "custom/header" .}}
</head>
<body>
{{template "custom/body_outer_pre" .}}

This comment has been minimized.

@bkcsoft

bkcsoft Jan 2, 2018

Member

custom/templates/custom/ ? :trollface:

This comment has been minimized.

@tboerger

tboerger Jan 2, 2018

Member

@bkcsoft just following the already existing templates custom/header.tmpl and custom/footer.tmpl.

This comment has been minimized.

@tboerger

tboerger Jan 2, 2018

Member
root@dchi: ~
<o> # tree /var/lib/docker/volumes/demo_gitea/_data/templates
/var/lib/docker/volumes/demo_gitea/_data/templates
└── base
    ├── head.tmpl
    ├── head.tmpl.master
    ├── head.tmpl.new
    └── head.tmpl.patch

:trollface:

This comment has been minimized.

@bkcsoft
@bkcsoft

bkcsoft approved these changes Jan 2, 2018

@bkcsoft

This comment has been minimized.

Member

bkcsoft commented Jan 2, 2018

LG-TM doesn't update on approvals 😢

@tboerger tboerger added lgtm/done and removed lgtm/need 1 labels Jan 2, 2018

@tboerger

This comment has been minimized.

Member

tboerger commented Jan 2, 2018

LG-TM doesn't update on approvals 😢

It updated?

@bkcsoft

This comment has been minimized.

Member

bkcsoft commented Jan 2, 2018

@tboerger only after commenting :(

@tboerger

This comment has been minimized.

Member

tboerger commented Jan 2, 2018

@tboerger only after commenting :(

Than @appleboy isn't listening to the correct events? Maybe raise an issue on the LGTM repo, or finally replace it with a simple bot :trollface:

@codecov-io

This comment has been minimized.

codecov-io commented Jan 2, 2018

Codecov Report

Merging #3286 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3286      +/-   ##
==========================================
+ Coverage    34.6%   34.82%   +0.21%     
==========================================
  Files         277      277              
  Lines       40263    40263              
==========================================
+ Hits        13935    14021      +86     
+ Misses      24283    24183     -100     
- Partials     2045     2059      +14
Impacted Files Coverage Δ
models/repo.go 43.38% <0%> (+0.18%) ⬆️
models/repo_indexer.go 51.94% <0%> (+0.97%) ⬆️
models/lfs.go 28.26% <0%> (+2.17%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️
modules/lfs/server.go 35.01% <0%> (+14.32%) ⬆️
modules/lfs/content_store.go 43.75% <0%> (+35.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a220377...88587af. Read the comment docs.

@bkcsoft bkcsoft merged commit c4a8d4c into go-gitea:master Jan 2, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@tboerger tboerger deleted the tboerger:additional-template-snippets branch Jan 2, 2018

@appleboy

This comment has been minimized.

Member

appleboy commented Jan 3, 2018

@tboerger @bkcsoft we need to re-enable the gitea repo for receive approval event.

I don't have permission to do this.

https://lgtm.gitea.io/go-gitea

@appleboy

This comment has been minimized.

Member

appleboy commented Jan 3, 2018

screen shot 2018-01-03 at 11 15 40 am

Please see the webhook setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment