Skip to content

support the open-icon of folder - #34168

Merged
lunny merged 17 commits into
go-gitea:mainfrom
kerwin612:support-folder-open-state
Apr 29, 2025
Merged

support the open-icon of folder#34168
lunny merged 17 commits into
go-gitea:mainfrom
kerwin612:support-folder-open-state

Conversation

@kerwin612

Copy link
Copy Markdown
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2025
@kerwin612
kerwin612 requested a review from wxiaoguang April 10, 2025 03:04
@wxiaoguang

This comment was marked as outdated.

@kerwin612

Copy link
Copy Markdown
Member Author

I think we need to decouple the "basic theme" and "material theme"

According to your suggestion, I've newly submitted two commits. I'm not sure if they achieve the decoupling you mentioned.

…eeEntry` to `FileEntry` to decouple it from `git.TreeEntry`.

This change will allow integrating the file icons of the file tree on the diff page into the unified rendering logic without relying on `git.TreeEntry`.
@wxiaoguang

This comment was marked as outdated.

@wxiaoguang
wxiaoguang marked this pull request as draft April 13, 2025 12:19
@kerwin612
kerwin612 marked this pull request as ready for review April 16, 2025 01:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2025
@wxiaoguang

This comment was marked as resolved.

@wxiaoguang
wxiaoguang removed their request for review April 22, 2025 07:11
@wxiaoguang
wxiaoguang marked this pull request as draft April 22, 2025 15:58
@kerwin612
kerwin612 marked this pull request as ready for review April 28, 2025 11:00
@kerwin612
kerwin612 requested a review from a team April 28, 2025 11:02
@kerwin612
kerwin612 requested review from hiifong and yp05327 April 29, 2025 00:06
@lunny lunny added this to the 1.25.0 milestone Apr 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2025
@kerwin612 kerwin612 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2025
@lunny
lunny merged commit 2b76993 into go-gitea:main Apr 29, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2025
@kerwin612
kerwin612 deleted the support-folder-open-state branch April 29, 2025 02:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 30, 2025
* giteaofficial/main:
  Fix some dropdown problems on the issue sidebar (go-gitea#34308)
  [skip ci] Updated translations via Crowdin
  Fix button alignments (go-gitea#34307)
  fix go version (go-gitea#34299)
  Fix the ci build (go-gitea#34309)
  support the open-icon of folder (go-gitea#34168)
  Fix wrong review requests when updating the pull request (go-gitea#34286)
  Enforce two-factor auth (2FA: TOTP or WebAuthn) (go-gitea#34187)
  actions artifacts api list/download check status upload confirmed (go-gitea#34273)
@kerwin612 kerwin612 added the outdated/backport/v1.24 This PR should be backported to Gitea 1.24 label Jun 29, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 29, 2025
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 29, 2025
silverwind pushed a commit that referenced this pull request Jun 30, 2025
Backport #34168 by @kerwin612

Co-authored-by: Kerwin Bryant <kerwin612@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.24 This PR should be backported to Gitea 1.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants