Fix the response format for actions/workflows. - #35009
Merged
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Jul 9, 2025
wxiaoguang
left a comment
wxiaoguang
left a comment
Contributor
There was a problem hiding this comment.
Also cc @bencurio and @ChristopherHX
GiteaBot
added
lgtm/need 1
ChristopherHX
approved these changes
Jul 9, 2025
ChristopherHX
left a comment
ChristopherHX
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I missed this in the original PR
I think adding a Backport label for 1.24 makes sense to fix the openapi there as well
GiteaBot
added
lgtm/done
ChristopherHX
added
the
outdated/backport/v1.24
Collaborator
|
I was unable to create a backport for 1.24. @ScionOfDesign, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
Contributor
|
Hmm, swagger conflict makes it impossible to backport automatically. If you'd like to try to backport, you can checkout 1.24 branch and apply the change to it again (manually 🤣 ) and submit a new PR targeting 1.24 branch. If there is any difficulty, other maintainers and I could also help. |
ChristopherHX
pushed a commit
to ChristopherHX/gitea
that referenced
this pull request
Jul 9, 2025
Backport go-gitea#35009 This PR fixes the response format for the OpenAPI Spec of `ActionsListRepositoryWorkflows`. It was specified in the OpenAPI spec as returning a `[]*ActionWorkflow`, but it actually should return a `api.ActionWorkflowResponse`. The test already expects an `api.ActionWorkflowResponse` like expected.
Contributor
|
We could improve the backport program here, e.g. if the only conflict is swagger delte the generated file, regenerate. I am doing this now manually |
silverwind
pushed a commit
that referenced
this pull request
Jul 9, 2025
Backport #35009 This PR fixes the response format for the OpenAPI Spec of `ActionsListRepositoryWorkflows`. It was specified in the OpenAPI spec as returning a `[]*ActionWorkflow`, but it actually should return a `api.ActionWorkflowResponse`. The test already expects an `api.ActionWorkflowResponse` like expected. Co-authored-by: Scion <Filiecs2@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 10, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Docs/fix typo and grammar in CONTRIBUTING.md (go-gitea#35024) fix: improve english grammar and readability in locale_en-US.ini (go-gitea#35017) Add labeler config for `topic/code-linting` (go-gitea#35020) Fix various problems (go-gitea#35012) Fix the response format for `actions/workflows`. (go-gitea#35009)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the response format for the OpenAPI Spec of
ActionsListRepositoryWorkflows.It was specified in the OpenAPI spec as returning a
[]*ActionWorkflow, but it actually should return aapi.ActionWorkflowResponse.The test already expects an
api.ActionWorkflowResponselike expected.