Skip to content

Fix corrupted external render content #35946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Fix corrupted external render content #35946

merged 1 commit into from
Nov 14, 2025
+60 −88

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 13, 2025

Fix #35944

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 13, 2025
@wxiaoguang wxiaoguang force-pushed the fix-external-render-content branch from ce756af to 2213c65 Compare November 13, 2025 07:00
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Nov 13, 2025

image

@wxiaoguang wxiaoguang mentioned this pull request Nov 13, 2025
Closed
wxiaoguang
wxiaoguang commented Nov 13, 2025
View reviewed changes
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Nov 13, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 13, 2025
Open
25 tasks
@wxiaoguang wxiaoguang force-pushed the fix-external-render-content branch from 2213c65 to 84146e8 Compare November 13, 2025 09:06
@wxiaoguang wxiaoguang force-pushed the fix-external-render-content branch from 84146e8 to 2de6af7 Compare November 13, 2025 09:15
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 13, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 14, 2025
Closed
@wxiaoguang wxiaoguang merged commit 1f3558b into go-gitea:main Nov 14, 2025
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 14, 2025
@wxiaoguang @GiteaBot
Fix corrupted external render content (go-gitea#35946)
442f90e 
Fix go-gitea#35944
@GiteaBot GiteaBot mentioned this pull request Nov 14, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Nov 14, 2025
@wxiaoguang wxiaoguang deleted the fix-external-render-content branch November 14, 2025 00:31
wxiaoguang added a commit that referenced this pull request Nov 14, 2025
@GiteaBot @wxiaoguang
Fix corrupted external render content (#35946) (#35950)
d67cd62 
Backport #35946 by wxiaoguang

Fix #35944

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

External render failed when content is binary

4 participants

@wxiaoguang @lunny @delvh @GiteaBot