Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 26, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 26, 2025
@silverwind
Copy link
Member

silverwind commented Nov 28, 2025

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is https://pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

@lunny
Copy link
Member Author

lunny commented Nov 29, 2025

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

Good idea. I sent #36055 to replace this one.

@lunny lunny closed this Nov 29, 2025
@lunny lunny deleted the lunny/mail branch November 29, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants