New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global code search support #3664

Merged
merged 6 commits into from Mar 16, 2018

Conversation

@lunny
Copy link
Member

lunny commented Mar 13, 2018

This PR added a code search UI on explore. When indexer is enabled, both guest user and login user could use the feature. Guest user will only search public codes and login user could also search private codes he could access.
image

lunny added some commits Mar 13, 2018

@lunny lunny added the kind/feature label Mar 13, 2018

@lunny lunny added this to the 1.5.0 milestone Mar 13, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #3664 into master will decrease coverage by 0.07%.
The diff coverage is 18.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage   35.86%   35.79%   -0.08%     
==========================================
  Files         287      287              
  Lines       41359    41489     +130     
==========================================
+ Hits        14835    14852      +17     
- Misses      24336    24449     +113     
  Partials     2188     2188
Impacted Files Coverage Δ
models/repo.go 42.67% <0%> (-0.08%) ⬇️
models/repo_list.go 56.37% <0%> (-9.25%) ⬇️
routers/routes/routes.go 87.6% <100%> (+0.02%) ⬆️
modules/search/search.go 77.1% <100%> (+0.27%) ⬆️
routers/repo/search.go 56% <100%> (+1.83%) ⬆️
routers/home.go 45.71% <6.52%> (-23.57%) ⬇️
modules/indexer/repo.go 64.28% <82.35%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4163cdf...3d388c6. Read the comment docs.

@lunny lunny added the changelog label Mar 13, 2018

@tboerger tboerger added lgtm/need 1 and removed lgtm/need 2 labels Mar 13, 2018

@sapk

sapk approved these changes Mar 13, 2018

@tboerger tboerger added lgtm/done and removed lgtm/need 1 labels Mar 13, 2018

@giudon

This comment has been minimized.

Copy link

giudon commented Mar 13, 2018

Thank you for this wonderful functionality guys. Can you release it on 1.4.0?

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Mar 13, 2018

@giudon 1.4.0 is already release candidate that means that no features will be added.

repo_no_results = No matching repositories have been found.
user_no_results = No matching users have been found.
org_no_results = No matching organizations have been found.
code_no_results = No matching code have been found.

This comment has been minimized.

@jonasfranz

jonasfranz Mar 13, 2018

Member

„code have been found“ should be changed to „code has been changed“

This comment has been minimized.

@lafriks

lafriks Mar 13, 2018

Member

Why changed?

This comment has been minimized.

@lunny

lunny Mar 14, 2018

Member

Maybe I should use No matching codes have been found.

This comment has been minimized.

@lunny

lunny Mar 14, 2018

Member

@JonasFranzDEV @lafriks done.

@@ -249,3 +249,28 @@ func SearchRepositoryByName(opts *SearchRepoOptions) (RepositoryList, int64, err

return repos, count, nil
}

// FindUserAccessiableRepoIDs find all accessiable repositories' ID by user's id
func FindUserAccessiableRepoIDs(userID int64) ([]int64, error) {

This comment has been minimized.

@jonasfranz

jonasfranz Mar 13, 2018

Member

does this include organization repos that could be accessed by the user?

This comment has been minimized.

@mbger

mbger Mar 13, 2018

And a typo in accessible?

This comment has been minimized.

@lunny

lunny Mar 14, 2018

Member

@JonasFranzDEV yes, included.
@mbger done.

lunny added some commits Mar 14, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 14, 2018

And I also add the UnitTypeCode check when login user is not admin.

@sapk

sapk approved these changes Mar 16, 2018

@lunny lunny merged commit 9e5d0a0 into go-gitea:master Mar 16, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/global_code_search branch Mar 16, 2018

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018

Merge tag 'v1.5.0-rc1' into wild/v1.5
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment