New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple assignees #3705

Merged
merged 119 commits into from May 9, 2018

Conversation

@kolaente
Copy link
Member

kolaente commented Mar 22, 2018

Blocked by go-gitea/go-sdk#99

This implements multiple assignees as of #1884. You can add and remove multiple assignees via the ui when creating issues or pull requests on the sidebar to the right as you do with labels.

I modified the api to reflect Github's API behavior while being backwards compatible.

Todo

  • Unit tests for new functions
  • Update go-sdk once it's merged

kolaente added some commits Mar 3, 2018

fmt
Added old assigneeID when creating an issue/pr
+ re-added setting to add assignees when creating a pr
Merge branch 'master' of https://github.com/go-gitea/gitea into multi…
…ple-assignees

# Conflicts:
#	models/migrations/migrations.go
#	models/migrations/v58.go
fmt
Fixed assignes showing up two times on issue page
+ smaller fixes and improvmentsk
@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 5, 2018

@lafriks This is intended, it shows all issues which are assigned to that user.

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 5, 2018

@koalente no, if you check to assign user to issue and then when you click outside dropdown it will redirect to issue list

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 5, 2018

@lafriks weired, I cannot reproduce that on Firefox 61 nor chromium 66.0.3359.139. This seems to be a client problem,which browser are you using?

I'll set up a testintance later this day.

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 5, 2018

Set up the test instance: https://gitea-dev.kolaente.de/

@lafriks Can you reproduce the issue over there?

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented May 6, 2018

@lafriks I could not reproduce that issue at my localhost instance using Firefox 59.0.2, Epiphany 3.18.11, or Chrome 66.0.3359.139.

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 8, 2018

@kolaente yes now it is fixed, when I tested it was not. Now it works as one expect. There is still small cavet that if you add assignees and than clear them without saving that new issue it will still try to redirect and asks if I want to navigate away from that page and have unsaved data.

@lafriks

lafriks approved these changes May 8, 2018

Copy link
Member

lafriks left a comment

That small remaining issue should probably needs to be fixed but probably it's not a blocking issue

lunny and others added some commits May 9, 2018

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 9, 2018

@lafriks great, I fixed that issue as well now.

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 9, 2018

@kolaente can't test right now but does this work also from issue list for batch issue assigning?

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 9, 2018

or at least does not break it's functionality

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 9, 2018

@lafriks Filtering issues by assignees (if that's what you mean) works as before, meaning you can show all issues which have at least the one person assigned you choose from a dropdown. It's currently not possible to filter by more than one assignee. I'll probably submit a PR for that once this one is merged.

kolaente added some commits May 9, 2018

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 9, 2018

@kolaente no I mean there is option to assign user to multiple issues from issue list, does it still work?

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 9, 2018

@lafriks Yes, this does still work, but only with one user at a time.

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 9, 2018

ok that's fine than. I was just wanted to be sure that it is not broken 👍

@kolaente

This comment has been minimized.

Copy link
Member

kolaente commented May 9, 2018

@lafriks ok, cool.
The CI fail seems unrelated, can someone restart?

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented May 9, 2018

@kolaente already did

@lafriks lafriks merged commit 95f2e2b into go-gitea:master May 9, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks added the changelog label May 9, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented May 10, 2018

@kolaente maybe update docs to add this to feature list and change the comparsion.

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018

Merge tag 'v1.5.0-rc1' into wild/v1.5
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)

@kolaente kolaente deleted the kolaente:multiple-assignees branch Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment