New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic support #3711

Merged
merged 13 commits into from Apr 11, 2018

Conversation

10 participants
@lunny
Copy link
Member

lunny commented Mar 23, 2018

This PR will view a repository's topics and let repositorys owners to manage topics.

Will fix #219

image

image

image

image

@lunny lunny added this to the 1.5.0 milestone Mar 23, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 23, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@1946ce2). Click here to learn what that means.
The diff coverage is 42.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3711   +/-   ##
=========================================
  Coverage          ?   23.02%           
=========================================
  Files             ?      126           
  Lines             ?    24894           
  Branches          ?        0           
=========================================
  Hits              ?     5731           
  Misses            ?    18287           
  Partials          ?      876
Impacted Files Coverage Δ
models/repo.go 17.32% <ø> (ø)
routers/repo/view.go 0% <0%> (ø)
routers/repo/topic.go 0% <0%> (ø)
models/topic.go 54.12% <54.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1946ce2...4a1f5a3. Read the comment docs.

@lunny lunny removed the status/wip label Mar 25, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 25, 2018

I think it's ready for review.

@lunny lunny force-pushed the lunny:lunny/topic branch from 9000eae to 49570bd Mar 27, 2018

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Mar 29, 2018

@lunny conflicted

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Mar 29, 2018

IMHO the color of the badges do not really fit to the design of gitea. We should use a sort of blue color (like links) or a green color like the logo.

@lunny lunny force-pushed the lunny:lunny/topic branch from 49570bd to ae7c9a3 Mar 29, 2018

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 29, 2018

conflict resolved. I will try to find another tag color.

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 29, 2018

@JonasFranzDEV changed to green basic style.

image

image

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Mar 29, 2018

When I create a new repo and add some topics it looks like:
screenshot-2018-3-29 as

When I reload it looks like:
screenshot-2018-3-29 as 1

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Mar 30, 2018

@JonasFranzDEV fixed.

throttle: 500,
cache: false,
onResponse: function(res) {
console.log(res)

This comment has been minimized.

@appleboy

appleboy Apr 1, 2018

Member

remove debug message?

},
});

$("span.sizer").change(function(){

This comment has been minimized.

@appleboy

appleboy Apr 1, 2018

Member

remove debug message.

This comment has been minimized.

@lunny

lunny Apr 9, 2018

Member

Done.

@lunny lunny force-pushed the lunny:lunny/topic branch from ce2a93c to 9eaa912 Apr 1, 2018

lunny added some commits Mar 23, 2018

@lunny lunny force-pushed the lunny:lunny/topic branch from 9eaa912 to be00702 Apr 9, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Apr 9, 2018

@@ -199,6 +199,7 @@ type Repository struct {
Size int64 `xorm:"NOT NULL DEFAULT 0"`
IndexerStatus *RepoIndexerStatus `xorm:"-"`
IsFsckEnabled bool `xorm:"NOT NULL DEFAULT true"`
Topics []string `xorm:"TEXT JSON"`

This comment has been minimized.

@lafriks

lafriks Apr 9, 2018

Member

Why is this saved to database?

This comment has been minimized.

@lunny

lunny Apr 10, 2018

Member

For better performance when we list all topics for every repository on repositories list UI.

@lafriks
Copy link
Member

lafriks left a comment

Don't like duplicated staff in database as it usually brings it to sometimes not being updated but ok

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Apr 10, 2018

lunny added some commits Apr 10, 2018

@lunny lunny merged commit bec69f7 into go-gitea:master Apr 11, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/topic branch Apr 11, 2018

@marbetschar

This comment has been minimized.

Copy link

marbetschar commented Apr 12, 2018

@lafriks any chance of a new stable version any time soon which contains the topics? can't get it soon enough 😍 🎉 🤣

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Apr 12, 2018

@marbetschar 1.5.0 is planned to be release at the end of May but most probably that will be rc1 + 2-3 weeks to get to 1.5.0 so it's June :)

@marbetschar

This comment has been minimized.

Copy link

marbetschar commented Apr 12, 2018

😱😱😱😱

🤣🤣

jonasfranz added a commit to jonasfranz/gitea that referenced this pull request May 6, 2018

Add topic support (go-gitea#3711)
* add topic models and unit tests

* fix comments

* fix comment

* add the UI to show or add topics for a repo

* show topics on repositories list

* fix test

* don't show manage topics link when no permission

* use green basic as topic label

* fix topic label color

* remove trace content

* remove debug function

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018

Merge tag 'v1.5.0-rc1' into wild/v1.5
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@Cyber1000

This comment has been minimized.

Copy link

Cyber1000 commented Jul 20, 2018

Sorry to ask here, but I don't know where else:
Can you search after topics, or is it at least planned?
For now it seems I only can put topics on a repo and see it in the repo list, but I can't click on time like on github and get all repos relatet to this topic ...

Thanks!

@William-LP

This comment has been minimized.

Copy link
Contributor

William-LP commented Jul 23, 2018

Hey, just tried under the last version 1.5.0-rc2 and it doesn't work :

image

image

Also the topics aren't clickable so this isn't possible to sort out the repo based on the topic

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Jul 23, 2018

Yes, searching and clicking on topics is currently not possible

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jul 23, 2018

This PR is a basic PR for topics. More PRs about topics are welcome!

@appleboy appleboy referenced this pull request Jul 24, 2018

Closed

Can't search repository by topic name #4504

2 of 7 tasks complete
@appleboy

This comment has been minimized.

Copy link
Member

appleboy commented Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment