New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableTimetracking option to app settings #3719

Merged
merged 3 commits into from Apr 9, 2018

Conversation

8 participants
@Bwko
Copy link
Member

Bwko commented Mar 25, 2018

Add an option to completely disable the time tracking feature.

@Bwko Bwko force-pushed the Bwko:time_tracker branch 2 times, most recently from c0b6c60 to 8369ae7 Mar 25, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #3719 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
+ Coverage   22.91%   22.92%   +<.01%     
==========================================
  Files         124      124              
  Lines       24750    24755       +5     
==========================================
+ Hits         5672     5675       +3     
- Misses      18216    18219       +3     
+ Partials      862      861       -1
Impacted Files Coverage Δ
models/repo_issue.go 0% <0%> (ø) ⬆️
modules/avatar/avatar.go 100% <0%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c81a1...c1d65a8. Read the comment docs.

@tboerger tboerger added lgtm/need 1 and removed lgtm/need 2 labels Mar 25, 2018

@lafriks lafriks added this to the 1.5.0 milestone Mar 25, 2018

@lafriks
Copy link
Member

lafriks left a comment

Also setting in repository settings should be hidden if global setting is set to false. Also would be nice if this would be added to admin server option list in UI

@@ -1172,6 +1173,7 @@ func newService() {
Service.EnableCaptcha = sec.Key("ENABLE_CAPTCHA").MustBool()
Service.DefaultKeepEmailPrivate = sec.Key("DEFAULT_KEEP_EMAIL_PRIVATE").MustBool()
Service.DefaultAllowCreateOrganization = sec.Key("DEFAULT_ALLOW_CREATE_ORGANIZATION").MustBool(true)
Service.EnableTimetracking = sec.Key("ENABLE_TIMETRACKING").MustBool(true)
Service.DefaultEnableTimetracking = sec.Key("DEFAULT_ENABLE_TIMETRACKING").MustBool(true)

This comment has been minimized.

@lafriks

lafriks Mar 25, 2018

Member

Shouldn't default be false if timetracking is disabled in server?

@Bwko Bwko force-pushed the Bwko:time_tracker branch 3 times, most recently from 9322027 to 37ec6d0 Mar 26, 2018

@Bwko

This comment has been minimized.

Copy link
Member

Bwko commented Mar 26, 2018

@lafriks I've updated my PR.

@Bwko Bwko force-pushed the Bwko:time_tracker branch from 37ec6d0 to f84e25f Mar 26, 2018

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Mar 28, 2018

@Bwko What is the default value of this option?

@Bwko

This comment has been minimized.

Copy link
Member

Bwko commented Mar 28, 2018

The time tracking is enabled by default

@lafriks

lafriks approved these changes Apr 9, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Apr 9, 2018

lafriks and others added some commits Apr 9, 2018

@lunny lunny merged commit 8ee45eb into go-gitea:master Apr 9, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@Bwko Bwko deleted the Bwko:time_tracker branch Apr 9, 2018

jonasfranz added a commit to jonasfranz/gitea that referenced this pull request May 6, 2018

@lafriks lafriks added the changelog label Jul 3, 2018

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018

Merge tag 'v1.5.0-rc1' into wild/v1.5
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment