New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow inactive users to access repositories using private keys #3887

Merged
merged 3 commits into from May 2, 2018

Conversation

5 participants
@lafriks
Member

lafriks commented May 2, 2018

Currently when disabling user he can still access repository using his private key when cloning/pushing using SSH

@lafriks lafriks added this to the 1.5.0 milestone May 2, 2018

@lunny

This comment has been minimized.

Member

lunny commented May 2, 2018

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 label May 2, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 2, 2018

Codecov Report

Merging #3887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3887   +/-   ##
=======================================
  Coverage   20.17%   20.17%           
=======================================
  Files         145      145           
  Lines       29151    29151           
=======================================
  Hits         5880     5880           
  Misses      22376    22376           
  Partials      895      895

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9495429...9cb8e1c. Read the comment docs.

@sapk

sapk approved these changes May 2, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels May 2, 2018

@lafriks lafriks merged commit b66d6b3 into go-gitea:master May 2, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lafriks lafriks deleted the lafriks:fix/ssh_inactive_user branch May 2, 2018

lafriks added a commit that referenced this pull request May 2, 2018

JonasFranzDEV added a commit to JonasFranzDEV/gitea that referenced this pull request May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment